Skip to content

Update the bool return type for Cuda and HIP bool info queries #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

Update the bool return type for Cuda and HIP bool info queries #1979

merged 1 commit into from
Sep 25, 2024

Conversation

MaryaSharf
Copy link
Contributor

@MaryaSharf MaryaSharf commented Aug 14, 2024 •
edited
Loading

This PR closes #1660

@github-actions github-actions bot added hip HIP adapter specific issues level-zero L0 adapter specific issues labels Aug 14, 2024
@MaryaSharf MaryaSharf force-pushed the marya/correct_return_type branch 2 times, most recently from aebe716 to 9f3a90d Compare August 16, 2024 22:40
@MaryaSharf MaryaSharf force-pushed the marya/correct_return_type branch 2 times, most recently from f45f94d to 3da54f2 Compare August 26, 2024 15:23
@github-actions github-actions bot added ci/cd Continuous integration/devliery cuda CUDA adapter specific issues labels Aug 30, 2024
@MaryaSharf MaryaSharf force-pushed the marya/correct_return_type branch 3 times, most recently from 1433d62 to c1a9155 Compare September 2, 2024 13:27
@MaryaSharf MaryaSharf changed the title Update the bool return type Update the bool return type for Cuda and HIP bool info queries Sep 2, 2024
@MaryaSharf MaryaSharf marked this pull request as ready for review September 2, 2024 13:29
@MaryaSharf MaryaSharf requested review from a team as code owners September 2, 2024 13:29
@MaryaSharf MaryaSharf requested a review from JackAKirk September 2, 2024 13:29
@npmiller npmiller removed ci/cd Continuous integration/devliery level-zero L0 adapter specific issues labels Sep 6, 2024
@MaryaSharf MaryaSharf force-pushed the marya/correct_return_type branch from 6520cbc to 4c42338 Compare September 8, 2024 22:47
@MaryaSharf MaryaSharf force-pushed the marya/correct_return_type branch from 4c42338 to 9e4ec24 Compare September 10, 2024 15:57
@npmiller npmiller added the ready to merge Added to PR's which are ready to merge label Sep 16, 2024
@npmiller
Copy link
Contributor

device num failure seems unrelated and happens on other PRs too, this should be good to merge (added ready to merge label)

@JackAKirk JackAKirk mentioned this pull request Sep 16, 2024
Open
@aarongreig aarongreig merged commit 8256ae2 into oneapi-src:main Sep 25, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackAKirk JackAKirk JackAKirk approved these changes

Assignees
No one assigned
Labels
cuda CUDA adapter specific issues hip HIP adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure the bool info queries are consistent
4 participants
@MaryaSharf @npmiller @JackAKirk @aarongreig