Fix bool return values in CUDA and HIP UR adapters

Author: MaryaSharf

source/adapters/hip/device.cpp

@@ -223,7 +223,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
     return ReturnValue(uint64_t{MaxAlloc});
   }
   case UR_DEVICE_INFO_IMAGE_SUPPORTED: {
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   }
   case UR_DEVICE_INFO_MAX_READ_IMAGE_ARGS: {
     // This call doesn't match to HIP as it doesn't have images, but instead
@@ -458,19 +458,19 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
     return ReturnValue(size_t(1000));
   }
   case UR_DEVICE_INFO_ENDIAN_LITTLE: {
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   }
   case UR_DEVICE_INFO_AVAILABLE: {
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   }
   case UR_DEVICE_INFO_BUILD_ON_SUBDEVICE: {
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   }
   case UR_DEVICE_INFO_COMPILER_AVAILABLE: {
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   }
   case UR_DEVICE_INFO_LINKER_AVAILABLE: {
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   }
   case UR_DEVICE_INFO_EXECUTION_CAPABILITIES: {
     auto Capability = ur_device_exec_capability_flags_t{
@@ -583,7 +583,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
     return ReturnValue(size_t(1024));
   }
   case UR_DEVICE_INFO_PREFERRED_INTEROP_USER_SYNC: {
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   }
   case UR_DEVICE_INFO_PARENT_DEVICE: {
     return ReturnValue(nullptr);
@@ -857,9 +857,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
     return ReturnValue(static_cast<uint32_t>(MaxRegisters));
   }
   case UR_DEVICE_INFO_MEM_CHANNEL_SUPPORT:
-    return ReturnValue(false);
+    return ReturnValue(ur_bool_t{false});
   case UR_DEVICE_INFO_IMAGE_SRGB:
-    return ReturnValue(false);
+    return ReturnValue(ur_bool_t{false});
   case UR_DEVICE_INFO_PCI_ADDRESS: {
     constexpr size_t AddressBufferSize = 13;
     char AddressBuffer[AddressBufferSize];
@@ -875,20 +875,20 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
                        strnlen(AddressBuffer, AddressBufferSize - 1) + 1);
   }
   case UR_DEVICE_INFO_HOST_PIPE_READ_WRITE_SUPPORTED:
-    return ReturnValue(false);
+    return ReturnValue(ur_bool_t{false});
   case UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT:
-    return ReturnValue(false);
+    return ReturnValue(ur_bool_t{false});
   case UR_DEVICE_INFO_ESIMD_SUPPORT:
-    return ReturnValue(false);
+    return ReturnValue(ur_bool_t{false});
   case UR_DEVICE_INFO_TIMESTAMP_RECORDING_SUPPORT_EXP:
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   case UR_DEVICE_INFO_ENQUEUE_NATIVE_COMMAND_SUPPORT_EXP: {
     // HIP supports enqueueing native work through the urNativeEnqueueExp
-    return ReturnValue(true);
+    return ReturnValue(ur_bool_t{true});
   }
 
   case UR_DEVICE_INFO_GLOBAL_VARIABLE_SUPPORT:
-    return ReturnValue(false);
+    return ReturnValue(ur_bool_t{false});
   // TODO: Investigate if this information is available on HIP.
   case UR_DEVICE_INFO_COMPONENT_DEVICES:
   case UR_DEVICE_INFO_COMPOSITE_DEVICE:

source/adapters/level_zero/device.cpp

@@ -947,7 +947,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
     return ReturnValue(UrRootDev);
   }
   case UR_DEVICE_INFO_COMMAND_BUFFER_SUPPORT_EXP:
-    return ReturnValue(true);
+    return ReturnValue(static_cast<ur_bool_t>(true));
   case UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP: {
     // Update support requires being able to update kernel arguments and all
     // aspects of the kernel NDRange.
@@ -965,19 +965,19 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
   }
   case UR_DEVICE_INFO_BINDLESS_IMAGES_SUPPORT_EXP: {
     // On L0 bindless images are supported.
-    return ReturnValue(true);
+    return ReturnValue(static_cast<ur_bool_t>(true));
   }
   case UR_DEVICE_INFO_BINDLESS_IMAGES_SHARED_USM_SUPPORT_EXP: {
     // On L0 bindless images can not be backed by shared (managed) USM.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_IMAGES_1D_USM_SUPPORT_EXP: {
     // On L0 1D bindless image USM are supported.
-    return ReturnValue(true);
+    return ReturnValue(static_cast<ur_bool_t>(true));
   }
   case UR_DEVICE_INFO_BINDLESS_IMAGES_2D_USM_SUPPORT_EXP: {
     // On L0 2D bindless image USM are supported.
-    return ReturnValue(true);
+    return ReturnValue(static_cast<ur_bool_t>(true));
   }
   case UR_DEVICE_INFO_IMAGE_PITCH_ALIGN_EXP:
   case UR_DEVICE_INFO_MAX_IMAGE_LINEAR_WIDTH_EXP:
@@ -988,76 +988,76 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
     return UR_RESULT_ERROR_INVALID_VALUE;
   case UR_DEVICE_INFO_MIPMAP_SUPPORT_EXP: {
     // L0 does not support mipmaps.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_MIPMAP_ANISOTROPY_SUPPORT_EXP: {
     // L0 does not support anisotropic filtering.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_MIPMAP_MAX_ANISOTROPY_EXP:
     logger::error("Unsupported ParamName in urGetDeviceInfo");
     logger::error("ParamName=%{}(0x{})", ParamName, logger::toHex(ParamName));
     return UR_RESULT_ERROR_INVALID_VALUE;
   case UR_DEVICE_INFO_MIPMAP_LEVEL_REFERENCE_SUPPORT_EXP: {
     // L0 does not support creation of images from individual mipmap levels.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_EXTERNAL_MEMORY_IMPORT_SUPPORT_EXP: {
     // L0 does not support importing external memory.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_EXTERNAL_SEMAPHORE_IMPORT_SUPPORT_EXP: {
     // L0 does not support importing external semaphores.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_CUBEMAP_SUPPORT_EXP: {
     // L0 does not support cubemaps.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_CUBEMAP_SEAMLESS_FILTERING_SUPPORT_EXP: {
     // L0 does not support cubemap seamless filtering.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_1D_USM_EXP: {
     // L0 does not support fetching 1D USM sampled image data.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_1D_EXP: {
     // L0 does not not support fetching 1D non-USM sampled image data.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_2D_USM_EXP: {
     // L0 does not support fetching 2D USM sampled image data.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_2D_EXP: {
     // L0 does not support fetching 2D non-USM sampled image data.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_SAMPLED_IMAGE_FETCH_3D_EXP: {
     // L0 does not support fetching 3D non-USM sampled image data.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_IMAGE_ARRAY_SUPPORT_EXP: {
     // L0 does not support image arrays
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_UNIQUE_ADDRESSING_PER_DIM_EXP: {
     // L0 does not support unique addressing per dimension
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_SAMPLE_1D_USM_EXP: {
     // L0 does not support sampling 1D USM sampled image data.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_BINDLESS_SAMPLE_2D_USM_EXP: {
     // L0 does not support sampling 1D USM sampled image data.
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   }
   case UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS:
-    return ReturnValue(false);
+    return ReturnValue(static_cast<ur_bool_t>(false));
   case UR_DEVICE_INFO_GLOBAL_VARIABLE_SUPPORT:
-    return ReturnValue(true);
+    return ReturnValue(static_cast<ur_bool_t>(true));
   default:
     logger::error("Unsupported ParamName in urGetDeviceInfo");
     logger::error("ParamNameParamName={}(0x{})", ParamName,