[DeviceSanitizer] Remove device global "__AsanDeviceGlobalCount" #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now UR already implemented API "urProgramGetGlobalVariablePointer", so we can use it to query the size of device globals. After that, we can remove "__AsanDeviceGlobalCount".
github-actions
bot
added
loader
AllanZyne
reviewed
May 7, 2024
AllanZyne
reviewed
May 7, 2024
pbalcer
approved these changes
Jun 12, 2024
pbalcer
added
ready to merge
|
There's quite a lot of stale changes in intel/llvm part of this. If this still needs to be merged, please rebase and update the intel/llvm PR. |
pbalcer
approved these changes
Nov 7, 2024
sommerlukas
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 19, 2024
…pass (#13678) Now UR already implemented API "urProgramGetGlobalVariablePointer", so we can use it to query the size of device globals and remove "__AsanDeviceGlobalCount". UR Part: oneapi-src/unified-runtime#1584 --------- Co-authored-by: Callum Fare <callum@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now UR already implemented API "urProgramGetGlobalVariablePointer", so we can use it to query the size of device globals and remove "__AsanDeviceGlobalCount".
SYCLOS Part: intel/llvm#13678