[DeviceSanitizer] Do sanitize for device globals in AddressSanitizer pass #13678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pass Now UR already implemented API "urProgramGetGlobalVariablePointer", so we can use it to query the size of device globals and remove "__AsanDeviceGlobalCount".
|
I suggest add a flag to control this feature. |
AllanZyne
reviewed
May 7, 2024
wenju-he
reviewed
May 9, 2024
Done |
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Oct 29, 2024
| if (SF->isIR() && (Name == "llvm.used" || Name == "llvm.compiler.used")) | ||
| // llvm.used and llvm.compiler.used and __AsanDeviceGlobalMetadata to | ||
| // the list of defined symbols. | ||
| if (SF->isIR() && |
There was a problem hiding this comment.
Since this is a device sanitizer specific change, it's better to only keep it in intel/llvm unless we have plans to upstream whole device sanitizer implementation.
wenju-he
approved these changes
Oct 30, 2024
llvm/test/Instrumentation/AddressSanitizer/SPIRV/device_global.ll
Outdated
Show resolved
Hide resolved
llvm/test/Instrumentation/AddressSanitizer/SPIRV/device_global_non_image_scope.ll
Outdated
Show resolved
Hide resolved
AllanZyne
approved these changes
Oct 30, 2024
AllanZyne
reviewed
Oct 30, 2024
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers Please merge |
callumfare
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now UR already implemented API "urProgramGetGlobalVariablePointer", so we can use it to query the size of device globals and remove "__AsanDeviceGlobalCount".
UR Part: oneapi-src/unified-runtime#1584