[DeviceSanitizer] Support detecting out-of-bounds errors on sycl::buffer #1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we discussed before, we intercepted buffer with usm for short-term solution. For long-term, we will draft a new ocl extension to allow user to create buffer with fixed address.
github-actions
bot
added
loader
yingcong-wu
reviewed
Apr 22, 2024
AllanZyne
approved these changes
May 6, 2024
|
@oneapi-src/unified-runtime-maintain, could you please help review this PR when you are available? Thanks. |
pbalcer
reviewed
May 7, 2024
pbalcer
approved these changes
May 8, 2024
|
@oneapi-src/unified-runtime-maintain, any other comments for this PR? Thanks. |
Don't think so. If you could make intel/llvm#13504 ready for review so to get approvals in place there before we merge here that would be great. |
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
May 31, 2024
… sycl::buffer (#13504) UR Part: oneapi-src/unified-runtime#1533 --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed before, we intercepted buffer with usm for short-term solution. For long-term, we will draft a new ocl extension to allow user to create buffer with fixed address.
SYCLOS PR for pre-ci: intel/llvm#13504