[DeviceSanitizer] Add e2e tests for detecting out-of-bounds errors on sycl::buffer #13504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaomaosu
requested review from
dm-vodopyanov,
aelovikov-intel,
AllanZyne,
yingcong-wu,
jinge90 and
wenju-he
AllanZyne
reviewed
May 22, 2024
| @@ -0,0 +1,34 @@ | |||
| // REQUIRES: linux, cpu | |||
There was a problem hiding this comment.
I think merging all these tests into a single .cpp file might be beneficial for CI load, but we can address it separately for the entire E2E suite at once.
Comment on lines
27
to
30
| item.get_global_id(0) * item.get_global_range(1) * | ||
| item.get_global_range(2) + | ||
| item.get_global_id(1) * item.get_global_range(2) + | ||
| item.get_global_id(2); |
There was a problem hiding this comment.
can be simplified using nd_item::get_global_linear_id().
|
|
||
| q.submit([&](sycl::handler &h) { | ||
| auto A = buf.get_access<sycl::access::mode::write>(h); | ||
| h.copy(&v[0], A); |
There was a problem hiding this comment.
Do we need the same for fill/memset?
There was a problem hiding this comment.
Thanks, updated. BTW, the case just wants to test that buffer copy/fill will not crash since in UR side we intercept all buffer related APIs with USM.
aelovikov-intel
approved these changes
May 24, 2024
kbenzie
approved these changes
May 31, 2024
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR Part: oneapi-src/unified-runtime#1533