Add missing ORM specs and fix bugs discovered #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
OmniAuth::Identity::Models::ActiveRecord
-based records from saving.OmniAuth::Identity::Models::CouchPotato
's#save
.OmniAuth::Identity::Models::Sequel
's#save
.::create
,#save
, and#persisted?
when not already defined.info
functionality which setname
based onfirst_name
,last_name
, ornickname
Changed
OmniAuth::Identity::SecurePassword
ripped from Rails 6-1-stableWhile writing specs, it was discovered to be incompatible with this gem's Sequel adapter.
In any case, the ripped version is only used when the
has_secure_password
macro is not yet defined in the class.Added
CC @nbibler