ArgumentError When Saving ActiveRecord-based Models

[nbibler]

The recent change to define an API on Model added a save definition. This, however, seems to conflict with the existing ActiveRecord implementation provided by Rails (where save accepts options) and the shim in this library, which do not allow for arguments.

This incompatibility results in errors when attempting to create records in Rails:

ArgumentError:
  wrong number of arguments (given 1, expected 0)
# /ruby/2.7.1/lib/ruby/gems/2.7.0/gems/omniauth-identity-3.0.6/lib/omniauth/identity/model.rb:85:in `save'

The new save definition introduced here a few days ago:

omniauth-identity/lib/omniauth/identity/model.rb

Lines 85 to 89 in 9f55885

	def save
	raise NotImplementedError unless defined?(super)
	super
	end

The existing ActiveRecord interface which does not override save and just inherits it:

omniauth-identity/lib/omniauth/identity/models/active_record.rb

Lines 5 to 9 in 9f55885

	module OmniAuth
	module Identity
	module Models
	class ActiveRecord < ::ActiveRecord::Base
	include OmniAuth::Identity::Model

[pboling]

Gah... this is very difficult to get right! Fixing.

[btalbot]

#108 (comment) is related to the new changes as well. I commented in the PR directly but can open a new issue if that is needed instead.

[pboling]

@btalbot Check out 3.0.8. I believe all is fixed.

[nbibler]

Thanks again, @pboling, I'll try to verify once today's mimemagic drama (see rails/rails#41750) subsides. 😁

[pboling]

@nbibler Hope it is all working for you now 💯

[nbibler]

@pboling: It is! App is currently running 3.0.8 as of March 25. No issues. 👍