Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(halo): addresses multiple info and low sec findings #2086

Merged
merged 9 commits into from
Oct 8, 2024
Merged

chore(halo): addresses multiple info and low sec findings #2086

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
45ad070
fix: reorder fields matching pb definition
chmllr Oct 7, 2024
22dac87
fix: check for strictly more than 1/3 of power
chmllr Oct 7, 2024
2495237
fix: simplify error handling
chmllr Oct 7, 2024
898e4bb
fix: optimize locking
chmllr Oct 7, 2024
0a1578a
chore: refactor sig verification
chmllr Oct 7, 2024
c5aa4fb
chore: clean up
chmllr Oct 7, 2024
af90dcd
chore: nil checks
chmllr Oct 7, 2024
aa821bb
chore: add a todo comment
chmllr Oct 8, 2024
3aa3de0
Merge branch 'main' into chmllr/sec-findings
chmllr Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: check for strictly more than 1/3 of power
  • Loading branch information
@chmllr
chmllr committed Oct 7, 2024
commit 22dac87f39a6813caed676142678d68c15e0e3a5
2 changes: 1 addition & 1 deletion halo/valsync/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ func (k *Keeper) insertValidatorSet(ctx context.Context, vals []*Validator, isGe
// Log a warn if any validator has 1/3 or more of the total power.
// This is a potential attack vector, as a single validator could halt the chain.
for address, power := range powers {
if power >= totalPower/3 && len(powers) > 1 {
if power > totalPower/3 && len(powers) > 1 {
log.Warn(ctx, "🚨 Validator has 1/3 or more of total power", nil,
"address", address.Hex(),
"power", power,
Expand Down