chore(halo): addresses multiple info and low sec findings #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmllr
changed the title
chmllr
changed the title
corverroos
approved these changes
Oct 8, 2024
octane/evmengine/keeper/evmmsgs.go
Outdated
| topicI := slices.Concat(events[i].Topics...) | ||
| topicJ := slices.Concat(events[j].Topics...) | ||
| if cmp := bytes.Compare(topicI, topicJ); cmp != 0 { | ||
| if cmp := slices.CompareFunc(events[i].Topics, events[j].Topics, bytes.Compare); cmp != 0 { |
There was a problem hiding this comment.
can we add a test for this please. It isn't obvious that this is the same logic.
There was a problem hiding this comment.
If this results in different ordering that before, we will get a app hash mismatch panic and the chain will stall. So lets ensure the ordering remains unchanged.
There was a problem hiding this comment.
In general, be vary careful when changing on-chain logic, since is must never change.
There was a problem hiding this comment.
Sure, will add a test!
There was a problem hiding this comment.
Test added. Inside the test, we're comparing the results of the new implementation to the results of the old one.
devbugging
approved these changes
Oct 8, 2024
chmllr
force-pushed
the
chmllr/sec-findings
branch
from
ff12b0b to
aa821bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses multiple informational and low security findings.
issue: none