Add Show Routes and Views #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omidbachari
force-pushed
the
route-to-show-pages
branch
from
cd32712
to
84301b6
Compare
|
RFR @cpjolicoeur |
| window.peopleList = new PeopleList | ||
| peopleList.fetch().then -> | ||
| $('.card').remove() | ||
| $.each(peopleList._byId, (_prop, person_data) -> |
There was a problem hiding this comment.
Backbone extends Model and Collection with a bunch of underscore methods built-in. http://backbonejs.org/#Collection-Underscore-Methods
So to loop through a collection you could just do peopleList.each (person) -> ...
There was a problem hiding this comment.
Another option here is to use native browser array iterator fns such as
[].forEach(...)
A lot of options :)
| "<a class='name virtual' id='<%= _url.split('/')[2].split('.')[0] %>' href='#'>" + | ||
| "<%= name %>" + | ||
| "</a>" + | ||
| "<span class='title'><%= title %></span>" | ||
| render: -> | ||
| @$el.html @template(@model.toJSON()) |
There was a problem hiding this comment.
FYI
toJSON should not be used for rendering to a template, its purpose is to serialize the data when sending it to the server.
Rather you should be doing a clone of the attributes and passing that to the template render fn
marionettejs/backbone.marionette#1476
✨
|
thanks @samccone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.