Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using toJSON for rendering templates #1476

Closed
jamesplease opened this issue Jun 11, 2014 · 7 comments
Closed

Stop using toJSON for rendering templates #1476

jamesplease opened this issue Jun 11, 2014 · 7 comments
Labels
enhancement
Milestone
v3.0.0

Comments

@jamesplease
Copy link
Member

Right now we're using toJSON to render templates.

Per this issue, and its resolution, we shouldn't be.

Instead, we should be cloning the attributes object for our templates explicitly. I'm talking _.clone(model.attributes).

Your next question might be...why does this matter at all? toJSON does the exact same thing...all it does is clone the attributes.

The difference is use cases. toJSON is called when you're persisting data to the server – it's meant to filter out any data you don't want to save. It's not at all meant to be used in views!

This lets you do things like:

  1. Get data back from the server that has time stored as a string
  2. Store that data as a moment in your model, within attributes
  3. Filter that out with toJSON
  4. Still have access to everything in render

This is a breaking change, but is necessary to get Marionette consistent w. Backbone. It'll also be a huge help to everyone who is trying to do something like the above, which is otherwise really difficult.
@samccone
Copy link
Member

👍

@jamesplease
Copy link
Member Author

ha this is already done

Thanks @thejameskyle for pointing that out :)

@jamesplease jamesplease modified the milestones: v2.1, v3.0.0 Jul 8, 2014
@cmaher cmaher mentioned this issue Jul 16, 2014
Closed
@cmaher
Copy link
Member

cmaher commented Jul 16, 2014

closing in favor of #1599

@cmaher cmaher closed this as completed Jul 16, 2014
@jamesplease
Copy link
Member Author

@cmaher, I think #1599 references the non-breaking change for v2.x, where we're still using toJSON, just in a manner that prepares us for this. This issue documents the ultimately breaking change where we swap out toJSON in 3.x.

@jamesplease jamesplease reopened this Jul 16, 2014
@samccone samccone mentioned this issue Jul 16, 2014
Merged
@samccone
Copy link
Member

fixed in #1659

@jamesplease
Copy link
Member Author

Reopening – this references a breaking change that can't happen until v3, hence the milestone.

@jamesplease jamesplease reopened this Aug 30, 2014
@jamesplease
Copy link
Member Author

Added to #1796

@jamesplease jamesplease mentioned this issue Dec 22, 2014
Open
8 tasks
jamesplease added a commit that referenced this issue Jan 7, 2015
@jamesplease
Refactor serializeData to no longer use toJSON.
ffb47c7 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
@jamesplease jamesplease mentioned this issue Jan 7, 2015
Closed
1 task
jamesplease added a commit that referenced this issue Jan 7, 2015
@jamesplease
Refactor serializeData to no longer use toJSON.
64771ee 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
jamesplease added a commit that referenced this issue Jan 7, 2015
@jamesplease
Refactor serializeData to no longer use toJSON.
7503594 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
jamesplease added a commit that referenced this issue Jan 7, 2015
@jamesplease
Refactor serializeData to no longer use toJSON.
ad0dafe 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
jamesplease added a commit that referenced this issue Jan 7, 2015
@jamesplease
Refactor serializeData to no longer use toJSON.
53dc7f1 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
jamesplease added a commit that referenced this issue Jan 7, 2015
@jamesplease
Refactor serializeData to no longer use toJSON.
2447ea6 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
jamesplease added a commit that referenced this issue Jan 29, 2015
@jamesplease @jasonLaster
Refactor serializeData to no longer use toJSON.
f9db557 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
jamesplease added a commit that referenced this issue Jan 30, 2015
@jamesplease @samccone
Refactor serializeData to no longer use toJSON.
d15fb66 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
jamesplease added a commit that referenced this issue Feb 4, 2015
@jamesplease
Refactor serializeData to no longer use toJSON.
f14b7eb 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves #1476
jasonLaster pushed a commit to jasonLaster/backbone.marionette that referenced this issue Mar 25, 2015
@jamesplease @jasonLaster
Refactor serializeData to no longer use toJSON.
7d42069 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves marionettejs#1476
@jasonLaster jasonLaster mentioned this issue Mar 25, 2015
Merged
jasonLaster pushed a commit to jasonLaster/backbone.marionette that referenced this issue Mar 25, 2015
@jamesplease @jasonLaster
Refactor serializeData to no longer use toJSON.
89145b2 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves marionettejs#1476
@samccone samccone mentioned this issue Apr 1, 2016
Closed
@paulfalgout paulfalgout mentioned this issue Apr 16, 2016
Closed
ahumphreys87 pushed a commit to ahumphreys87/backbone.marionette that referenced this issue Aug 21, 2016
@jamesplease @ahumphreys87
Refactor serializeData to no longer use toJSON.
d1e9dce 
toJSON should only be used for preparing data to be sent to the
server. In addition, serializeData no longer accepts arguments,
distinguishing it further from templateHelpers.

Resolves marionettejs#1476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
3 participants
@samccone @cmaher @jamesplease