OMERO5DEV__3: fileset image linkage #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily concerned with fixing the graph specifications for delete, etc in spec.xml and handling the linkage from and to Image.
Contributor
|
Tested with import, chgrp and delete on images and plates. Direct feedback to @joshmoore resulting in two most recent commits. May need more testing? |
Member
Author
|
@pwalczysko / @jburel : the remaining issue as I understood it was chgrp of plate. This was likely broken before this PR, no? |
Member
|
@joshmoore Certainly does not seem to work with today's build (develop) on Gretzky. See below |
Contributor
|
In that case I'm happy for the PR to be merged if chgrp of Plate it outwith this PR. |
Member
Author
|
@pwalczysko, sorry, I meant before this PR was opened. |
Member
|
@joshmoore: change group for plate did not work prior to the PR. |
Member
Author
|
@jburel: thanks. @chris-allan said he would do without the upgrade script. Ok to merge? |
jburel
added a commit
that referenced
this pull request
Mar 28, 2013
OMERO5DEV__3: fileset image linkage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed recently, all images should link directly to
the Fileset that created them (or null if synthetic). Plate
no longer has a direct link to the Image, which simplies
several queries.
Import should continue to work and delete and chgrp for
images/filesets should all still work with the same
caveats for all multi-file images as previously.
Note: fstest/model.py still needs minor changes but
that conflicts with gh-941.