Skip to content

Conversation

@mtbc
Copy link
Member

@mtbc mtbc commented Feb 20, 2013

In #669 I broke PublicRepositoryI.listFiles. This attempts to fix it. Using the command-line interface to try getting a repository and listing the files would be a good test. @joshmoore will have some thoughts on testing too.

@joshmoore
Copy link
Member

Windows is certainly looking good:

In [3]: m.proxies[1].list(".")
Out[3]: ['/root_0']

In [4]: m.proxies[1].list("/")
Out[4]: ['/root_0']

I'll test more with my repository.py changes in just a bit.

@joshmoore
Copy link
Member

My repository.py is now completely passing locally. I'll open a PR with it shortly, but this can certainly be assumed to be working. Thanks, Mark.

joshmoore added a commit that referenced this pull request Feb 20, 2013
Fix public repository listFiles method that I broke with PR669.
@joshmoore joshmoore merged commit e95e195 into ome:develop Feb 20, 2013
joshmoore added a commit to joshmoore/openmicroscopy that referenced this pull request Mar 25, 2013
@sbesson sbesson modified the milestones: 5.0.0, 5.0.0-alpha1 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants