Skip to content

Conversation

@atarkowska
Copy link
Member

This is the same as gh-2597 but rebased onto develop.


The Preview viewport should now resize when the right panel is resized.

To test:

  • Browse to an Image and select the "Preview" tab on right.
  • Resize the right panel, using the drag handle.
  • The viewport should resize when you stop the drag (larger and smaller).
  • When a new image is selected and loaded into viewport, should still fit current size.
  • Various combinations of change in panel size, tab selection and image selection should "just work".

@atarkowska atarkowska mentioned this pull request Jul 7, 2014
@atarkowska
Copy link
Member Author

--rebased-from #2597

@gusferguson
Copy link

@aleksandra-tarkowska @will-moore
Tested using http://trout.openmicroscopy.org/merge/webclient/ Mac Firefox, Safari and Chrome user-3 read-annotate-1

Firefox and Safari:

  • select image in centre pane
  • click on Preview tab
  • image fills Preview viewer - screenshot 1
  • increase size of Preview pane
  • viewer increases in size, but image stays same size within viewer - screenshot 2
  • select different image in centre pane
  • image fills Preview viewer i.e. is scaled up - screenshot 3
  • reduce size of Preview pane
  • Preview viewer reduces in size but image stays same - screenshot 4
  • can't see areas of the image

Chrome:

  • same as above except even when you select a different image after increasing the size of the Preview pane, the new image does not scale up to fill the Preview viewer - get grey margins.

I think as the size of the Preview viewer changes with resizing of the pane, the image being viewed should be scaled to reflect the change in size of the viewer.

As it is in Chrome, it is completely pointless to have the viewer resize as the image never resizes, and in the other two browsers, I have to click on another image and then click back to the one I was viewing to benefit from the resized viewer.

webclient 4

webclient 3

webclient 2

webclient

@atarkowska
Copy link
Member Author

@gusferguson I see what you mean. As this is rebase lets merge it as it is to minimize confusion. I will fix it in the new PR.

@gusferguson
Copy link

@aleksandra-tarkowska - sounds good - less confusion always = better!

joshmoore added a commit that referenced this pull request Jul 8, 2014
…eview_resize_12319

Preview resize 12319 (rebased onto develop)
@joshmoore joshmoore merged commit c577605 into ome:develop Jul 8, 2014
@joshmoore joshmoore deleted the rebased/develop/preview_resize_12319 branch July 8, 2014 09:33
@will-moore
Copy link
Member

This is the same behaviour as if you resize the main image viewer window. E.g. set image to 100%, resize window, image stays at 100%. If you want to zoom more after resizing then you can do that. This would seem to me to be the expected behaviour.

@sbesson sbesson added this to the 5.1.0-m1 milestone Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants