Skip to content

Conversation

@will-moore
Copy link
Member

The Preview viewport should now resize when the right panel is resized.

To test:

  • Browse to an Image and select the "Preview" tab on right.
  • Resize the right panel, using the drag handle.
  • The viewport should resize when you stop the drag (larger and smaller).
  • When a new image is selected and loaded into viewport, should still fit current size.
  • Various combinations of change in panel size, tab selection and image selection should "just work".

@mtbc
Copy link
Member

mtbc commented Jun 11, 2014

Seems to work fine, good to merge.

(Small RFE I noticed: tall, thin images are shrunk more than necessary so as to fit in the square view port thing -- it narrows as necessary but also shrinks vertically when maybe it needn't.)

@atarkowska
Copy link
Member

Works nicely although I couldn't resize window on IE8 & 9, only 10

@will-moore
Copy link
Member Author

Seems to be mostly working in IE8 for me. OK to merge?

screen shot 2014-06-25 at 08 27 41

screen shot 2014-06-25 at 08 27 16

@atarkowska
Copy link
Member

that seems to be true for regular image, but not big image

@will-moore
Copy link
Member Author

Ah, OK. Seems that neither left nor right panels can be resized once a Big Image is displayed in Preview panel in IE8 (needs a full page refresh to fix). But this bug is not related to this PR. Can we merge now and fix that later?

@atarkowska
Copy link
Member

ok, np, please create a ticket for that

@will-moore
Copy link
Member Author

@joshmoore
Copy link
Member

Thanks all. Merging.

joshmoore added a commit that referenced this pull request Jul 4, 2014
@joshmoore joshmoore merged commit 120ce2e into ome:dev_5_0 Jul 4, 2014
@joshmoore joshmoore deleted the preview_resize_12319 branch July 4, 2014 10:47
@atarkowska
Copy link
Member

--rebased-to #2762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants