Adding type to data okta group

[dangoslen]

Re-creating this PR from #155 since I royally screwed up a merge. I believe I have merged this much better now and should be only additions for the functionality I'm attempting to implement.

---

Description for original PR:

This PR adds the ability to filter by a type in the okta_group data entity.

This is useful in cases were Okta is managed groups from multiple sources (LDAP, Google groups, etc.) that have the same name but different types.

It additionally returns the type as an attribute of the entity.

[tgoodsell-tempus]

https://github.com/oktadeveloper/terraform-provider-okta/blob/7231dbe0ca30154c8f40508da6b51c95091f9fb3/okta/data_source_okta_group.go#L63

This should be changed to optionally include the type if used, maybe something like:

if err != nil {
		return fmt.Errorf("failed to query for groups: %v", err)
	} else if len(groups) < 1 {
                if d.Get("type") != nil {
                    return fmt.Errorf("Group \"%s\" not found with type \"%s\"", name, d.Get("type").(string))
               } else {
	           return fmt.Errorf("Group \"%s\" not found", name)
              }
	}

[dangoslen]

@tgoodsell-tempus mind taking another look at this? TY

[tgoodsell-tempus]

LGTM!

[bogdanprodan-okta]

Default is interface{}, so it will set 0 as a default group type

[dangoslen]

🤔 I'm trying to read up on where that comes from - can you give me an article or documentation reference to look at?

[bogdanprodan-okta]

I think this has something to do with how the terraform converts values from the interface into the value. Because type is schema.TypeString, I think it just represents false as 0 (because false internally is just integer) and then converts it into the string (using strings.Itoa I guess), which is "0".