Adding type to data okta group #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
noinarisak
added
enhancement
|
@noinarisak Any chance we could get this an expedited review? I've found that being able to set the |
| Optional: true, | ||
| Default: false, | ||
| Description: "Type of the group. When specified in the terraform resource, will act as a filter when searching for the group", | ||
| }, |
There was a problem hiding this comment.
Could you please add a validation function for group types?
https://developer.okta.com/docs/reference/api/groups/#group-type
| if d.Get("type") != nil { | ||
| groupType := d.Get("type").(string) | ||
| searchParams = &query.Params{Q: name, Type: groupType} | ||
| } |
There was a problem hiding this comment.
This can be simplified
if d.Get("type") != nil {
searchParams.Type = d.Get("type").(string)
}
|
Sorry - I royally screwed up the merge from master down. Will open a new PR if that is ok with you @bogdanprodan-okta |
|
Sure, go ahead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to filter by a
typein theokta_groupdata entity.This is useful in cases were Okta is managed groups from multiple sources (LDAP, Google groups, etc.) that have the same name but different types.
It additionally returns the type as an attribute of the entity.