Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OKTA-526761: Add Caching support #768

Merged
merged 22 commits into from
Oct 6, 2022
Merged

OKTA-526761: Add Caching support #768

merged 22 commits into from
Oct 6, 2022

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Oct 4, 2022 •
edited
Loading

Issue(s)

Description

⚠️ Merge Target - oasv3 feature branch.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the base branch from master to oasv3 October 4, 2022 18:16
@arvindkrishnakumar-okta arvindkrishnakumar-okta marked this pull request as ready for review October 6, 2022 14:44
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title [WIP] OKTA-526761: Add caching support OKTA-526761: Add caching support Oct 6, 2022
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title OKTA-526761: Add caching support OKTA-526761: Add Caching support Oct 6, 2022
JayNewstrom
JayNewstrom reviewed Oct 6, 2022
View reviewed changes
Copy link

@JayNewstrom JayNewstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions/comments:

  • Was the cache framework copied from another repo?
  • We should add integration tests as well, we have some unit test coverage of the new functionality, but we haven't tested a lot of the more complex logic in the mustache template.
  • I don't think we should enable this by default, given that I'd expect most consumers to run multiple app server instances.

README.md Outdated Show resolved Hide resolved
api/src/main/java/com/okta/sdk/cache/Cache.java Show resolved Hide resolved
api/src/main/resources/custom_templates/ApiClient.mustache Show resolved Hide resolved
impl/src/test/groovy/com/okta/sdk/impl/cache/DefaultCacheTest.groovy Show resolved Hide resolved
@arvindkrishnakumar-okta
Copy link
Contributor Author

A few questions/comments:

  • Was the cache framework copied from another repo?
  • We should add integration tests as well, we have some unit test coverage of the new functionality, but we haven't tested a lot of the more complex logic in the mustache template.
  • I don't think we should enable this by default, given that I'd expect most consumers to run multiple app server instances.
  • Yes, like I mentioned earlier we simple ported the existing cache impl of v2 SDK into v3 to keep it less effort intensive.
  • Most of the new functionality is around integrating cache with the existing ApiClient of the v3 SDK. I have written UTs for Cache implementation, adding ITs for Caching might be tricky, I think.

@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit 44bed7a into oasv3 Oct 6, 2022
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the ak-okta-526761-add-caching-support branch October 6, 2022 16:13
arvindkrishnakumar-okta added a commit that referenced this pull request Oct 26, 2022
@arvindkrishnakumar-okta
Merge oasv3 feature branch into master - Prep for OASv3 Release (#…
8be490d 
…776)

* Regenerate and rewrite for OASv3 using `openapi-generator.tech` (#737)


* minor refactor

* minor refactor

* fix Travis build failure

* added circle ci config

* added jdk18 to circle ci config

* minor refactor

* minor refactor

* minor refactor

* minor refactor

* removed unwanted file

* updated readme and migrating guides and other refactoring

* [maven-release-plugin] prepare release okta-sdk-root-10.0.0-beta

* [maven-release-plugin] prepare for next development iteration

* Release pr 10.0.0 beta (#747)

* [maven-release-plugin] prepare release okta-sdk-root-10.0.0-beta

* [maven-release-plugin] prepare for next development iteration

* Update README.md

* Add support for custom user profile attributes (#749)

* add support for custom user profile attributes

* added license header on new files

* fix build failure

* refactored

* refactored

* refactored

* [OASv3] - OAuth for Okta (#753)

* wip - oauth for okta

* fix unit test failure

* fix unit test failure

* OKTA-526761: Add Caching support (#768)

* add caching

* OKTA-537443: Add Groups ITs (#772)

added GroupsIT

* OKTA-537444: Add Policy ITs (#773)

* added PoliciesIT (signon)

* Regen sdk with latest oasv3 spec (#774)

* added PoliciesIT (signon)

* updated PolicyIT

* regen and refactor sdk with latest oasv3 spec

* minor update

* fix build

* cve fix and prep for oasv3 GA release (#777)

* cve fix and prep for oasv3 GA release

* removed unwanted yaml file

* revert jakarta annotation back to 1.3.5

* updated migration guide

* updated circle ci config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayNewstrom JayNewstrom JayNewstrom approved these changes

@jaynewstrom-okta jaynewstrom-okta Awaiting requested review from jaynewstrom-okta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvindkrishnakumar-okta @JayNewstrom