Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate and rewrite for OASv3 using openapi-generator.tech #737

Merged

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented May 12, 2022

Issue(s)

Description

Use https://github.com/OpenAPITools/openapi-generator for OASv3 code gen.

Scope:

  1. Generate SDK components using off the shelf openapi-generator with no code changes to the code generation process/tooling. Templating changes are done.
  2. Rewrite SDK internals to work with the generated models.
  3. For Initial Beta version the following list of areas are out of scope - OAuth2 support, Caching support, Limited set of ITs (ITs cover just Users, Apps and IdP APIs).
  4. Open API Spec v3 is not available publicly in NPM yet. Therefore, the SDK will temporarily use a local copy of the spec file in src/swagger/api.yaml until NPM spec release is available. This SDK uses the no-enums variant of the spec generated by the project okta-oas3.
  5. This PR will be merged to feature branch oasv3 and the OASv3 SDK release will be done from this feature branch.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title wip - use openapi-generator.tech [DRAFT] - use openapi-generator.tech May 12, 2022
@arvindkrishnakumar-okta arvindkrishnakumar-okta force-pushed the ak_okta_492387_spike_openapi_tools_codegen branch from 6b7bc49 to f08f53b Compare May 18, 2022 15:49
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title [DRAFT] - use openapi-generator.tech [DRAFT] - OASv3 use openapi-generator.tech May 20, 2022
@arvindkrishnakumar-okta arvindkrishnakumar-okta force-pushed the ak_okta_492387_spike_openapi_tools_codegen branch from 59a5273 to 60cecb0 Compare July 27, 2022 01:37
@arvindkrishnakumar-okta arvindkrishnakumar-okta marked this pull request as ready for review July 29, 2022 12:31
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title [DRAFT] - OASv3 use openapi-generator.tech Regenerate and rewrite SDK for OASv3 using openapi-generator.tech Jul 29, 2022
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title Regenerate and rewrite SDK for OASv3 using openapi-generator.tech Regenerate and rewrite for OASv3 using openapi-generator.tech Jul 29, 2022
@arvindkrishnakumar-okta arvindkrishnakumar-okta force-pushed the ak_okta_492387_spike_openapi_tools_codegen branch from 5784cd5 to 73bb318 Compare July 29, 2022 17:59
@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit e666d89 into oasv3 Aug 2, 2022
arvindkrishnakumar-okta added a commit that referenced this pull request Oct 26, 2022
…776)

* Regenerate and rewrite for OASv3 using `openapi-generator.tech` (#737)


* minor refactor

* minor refactor

* fix Travis build failure

* added circle ci config

* added jdk18 to circle ci config

* minor refactor

* minor refactor

* minor refactor

* minor refactor

* removed unwanted file

* updated readme and migrating guides and other refactoring

* [maven-release-plugin] prepare release okta-sdk-root-10.0.0-beta

* [maven-release-plugin] prepare for next development iteration

* Release pr 10.0.0 beta (#747)

* [maven-release-plugin] prepare release okta-sdk-root-10.0.0-beta

* [maven-release-plugin] prepare for next development iteration

* Update README.md

* Add support for custom user profile attributes (#749)

* add support for custom user profile attributes

* added license header on new files

* fix build failure

* refactored

* refactored

* refactored

* [OASv3] - OAuth for Okta (#753)

* wip - oauth for okta

* fix unit test failure

* fix unit test failure

* OKTA-526761: Add Caching support (#768)

* add caching

* OKTA-537443: Add Groups ITs (#772)

added GroupsIT

* OKTA-537444: Add Policy ITs (#773)

* added PoliciesIT (signon)

* Regen sdk with latest oasv3 spec (#774)

* added PoliciesIT (signon)

* updated PolicyIT

* regen and refactor sdk with latest oasv3 spec

* minor update

* fix build

* cve fix and prep for oasv3 GA release (#777)

* cve fix and prep for oasv3 GA release

* removed unwanted yaml file

* revert jakarta annotation back to 1.3.5

* updated migration guide

* updated circle ci config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant