Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Java Parent to 32 and few misc dep upgrades #1520

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Bump Java Parent to 32 and few misc dep upgrades #1520

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f50eb8
Bump Java Parent to 32 and few misc dep upgrades
arvindkrishnakumar-okta Jun 27, 2024
74d608c
fixed pmd error
arvindkrishnakumar-okta Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/com/okta/sdk/client/AuthorizationMode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public enum AuthorizationMode {
private static final Map<AuthenticationScheme, AuthorizationMode> lookup = new HashMap<>();

static {
for (AuthorizationMode authorizationMode : AuthorizationMode.values()) {
for (AuthorizationMode authorizationMode : values()) {
arvindkrishnakumar-okta marked this conversation as resolved.
Show resolved Hide resolved
lookup.put(authorizationMode.getAuthenticationScheme(), authorizationMode);
}
}
Expand Down
6 changes: 4 additions & 2 deletions impl/src/main/java/com/okta/sdk/impl/config/DefaultPropertiesParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ public Map<String, String> parse(String source) {

@Override
public Map<String, String> parse(Resource resource) throws IOException {
InputStream is = resource.getInputStream();
Scanner scanner = new Scanner(is, StandardCharsets.UTF_8.name());
Scanner scanner;
arvindkrishnakumar-okta marked this conversation as resolved.
Show resolved Hide resolved
try (InputStream inputStream = resource.getInputStream()) {
scanner = new Scanner(inputStream, StandardCharsets.UTF_8.name());
}
return parse(scanner);
}

Expand Down
2 changes: 2 additions & 0 deletions impl/src/main/java/com/okta/sdk/impl/oauth2/DPoPInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ private DPopHandshakeState handleHandshakeResponse(JsonNode errorField, Header n
this.nonceValidUntil = Instant.now().plusSeconds(NONCE_VALID_SECONDS);
return DPopHandshakeState.FIRST_USE_DPOP_NONCE;
}
default:
arvindkrishnakumar-okta marked this conversation as resolved.
Show resolved Hide resolved
return DPopHandshakeState.UNEXPECTED_STATE;
}
}
return DPopHandshakeState.UNEXPECTED_STATE;
Expand Down
10 changes: 5 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>com.okta</groupId>
<artifactId>okta-parent</artifactId>
<version>30</version>
<version>32</version>
</parent>

<groupId>com.okta.sdk</groupId>
Expand All @@ -34,13 +34,13 @@
<inceptionYear>2017</inceptionYear>

<properties>
<jackson.version>2.17.0</jackson.version>
<jackson.version>2.17.1</jackson.version>
<snakeyaml.version>2.2</snakeyaml.version>
<bouncycastle.version>1.78</bouncycastle.version>
<jjwt.version>0.12.5</jjwt.version>
<bouncycastle.version>1.78.1</bouncycastle.version>
<jjwt.version>0.12.6</jjwt.version>
<org.apache.httpcomponents.client5.version>5.3.1</org.apache.httpcomponents.client5.version>
<okta.sdk.previousVersion>17.0.0</okta.sdk.previousVersion>
<okta.commons.version>1.3.5</okta.commons.version>
<okta.commons.version>1.3.6</okta.commons.version>
<com.google.auto.service.version>1.1.1</com.google.auto.service.version>
<github.slug>okta/okta-sdk-java</github.slug>
</properties>
Expand Down