Bump Java Parent to 32 and few misc dep upgrades (#1520)

* Bump Java Parent to 32 and few misc dep upgrades * fixed pmd error
okta · Jun 28, 2024 · e11a28d · e11a28d
1 parent 12fcfe1
commit e11a28d
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/api/src/main/java/com/okta/sdk/client/AuthorizationMode.java b/api/src/main/java/com/okta/sdk/client/AuthorizationMode.java
@@ -33,7 +33,7 @@ public enum AuthorizationMode {
     private static final Map<AuthenticationScheme, AuthorizationMode> lookup = new HashMap<>();
 
     static {
-        for (AuthorizationMode authorizationMode : AuthorizationMode.values()) {
+        for (AuthorizationMode authorizationMode : values()) {
             lookup.put(authorizationMode.getAuthenticationScheme(), authorizationMode);
         }
     }

diff --git a/examples/quickstart/src/main/java/quickstart/ReadmeSnippets.java b/examples/quickstart/src/main/java/quickstart/ReadmeSnippets.java
@@ -52,7 +52,7 @@ public class ReadmeSnippets {
     private static final Logger log = LoggerFactory.getLogger(ReadmeSnippets.class);
 
     private final ApiClient client = Clients.builder().build();
-    private final User user = null;
+    private static final User user = null;
 
     private void createClient() {
         ApiClient client = Clients.builder()

diff --git a/impl/src/main/java/com/okta/sdk/impl/config/DefaultPropertiesParser.java b/impl/src/main/java/com/okta/sdk/impl/config/DefaultPropertiesParser.java
@@ -45,8 +45,10 @@ public Map<String, String> parse(String source) {
 
     @Override
     public Map<String, String> parse(Resource resource) throws IOException {
-        InputStream is = resource.getInputStream();
-        Scanner scanner = new Scanner(is, StandardCharsets.UTF_8.name());
+        Scanner scanner;
+        try (InputStream inputStream = resource.getInputStream()) {
+            scanner = new Scanner(inputStream, StandardCharsets.UTF_8.name());
+        }
         return parse(scanner);
     }
 

diff --git a/impl/src/main/java/com/okta/sdk/impl/oauth2/DPoPInterceptor.java b/impl/src/main/java/com/okta/sdk/impl/oauth2/DPoPInterceptor.java
@@ -159,6 +159,8 @@ private DPopHandshakeState handleHandshakeResponse(JsonNode errorField, Header n
                     this.nonceValidUntil = Instant.now().plusSeconds(NONCE_VALID_SECONDS);
                     return DPopHandshakeState.FIRST_USE_DPOP_NONCE;
                 }
+                default:
+                    return DPopHandshakeState.UNEXPECTED_STATE;
             }
         }
         return DPopHandshakeState.UNEXPECTED_STATE;

diff --git a/pom.xml b/pom.xml
@@ -20,7 +20,7 @@
     <parent>
         <groupId>com.okta</groupId>
         <artifactId>okta-parent</artifactId>
-        <version>30</version>
+        <version>32</version>
     </parent>
 
     <groupId>com.okta.sdk</groupId>
@@ -34,13 +34,13 @@
     <inceptionYear>2017</inceptionYear>
 
     <properties>
-        <jackson.version>2.17.0</jackson.version>
+        <jackson.version>2.17.1</jackson.version>
         <snakeyaml.version>2.2</snakeyaml.version>
-        <bouncycastle.version>1.78</bouncycastle.version>
-        <jjwt.version>0.12.5</jjwt.version>
+        <bouncycastle.version>1.78.1</bouncycastle.version>
+        <jjwt.version>0.12.6</jjwt.version>
         <org.apache.httpcomponents.client5.version>5.3.1</org.apache.httpcomponents.client5.version>
         <okta.sdk.previousVersion>17.0.0</okta.sdk.previousVersion>
-        <okta.commons.version>1.3.5</okta.commons.version>
+        <okta.commons.version>1.3.6</okta.commons.version>
         <com.google.auto.service.version>1.1.1</com.google.auto.service.version>
         <github.slug>okta/okta-sdk-java</github.slug>
     </properties>