[FW][ADD] UI: odoo spreadsheets svg icons #13524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@samueljlieber this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
X-original-commit: a35a208
samueljlieber
force-pushed
the
master-master-ui-icons-spreadsheet-sali-438549-fw
branch
from
5323eb9 to
51c9458
Compare
|
@samueljlieber this PR was modified / updated and has become a normal PR. It must be merged directly. |
|
|
@robodoo r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: #4792034
This PR proposes introducing the o-spreadsheet icons into the Odoo documentation.
How this works
The Spreadsheet library in Odoo contains two QWeb template files for SVG icons:
These were used to generate an SVG sprite file (
extensions/odoo_theme/static/img/odoo-spreadsheet-icons.svg), which can then be utilized by the SVG<use>element to call nodes by ID in the sprite.This SVG sprite file is then included in the main page layout (
extensions/odoo_theme/layout.html)The RST
:icon:role was updated to accomodate anos-*icon specifier.The SVG sprite file can be generated automatically via a simple script outlined in this gist:
https://gist.github.com/samueljlieber/5ae7648a5ca08e0bfc8455861825e2ff
Why?
Example
With this implementation, o-spreadsheet icons can be used like so:
Forward-Port-Of: #13386