list: traverse nested dir symlinks #96
Conversation
Addresses issue odeke-em#80 and fixes commit 7f7dea5. The proper path of the symlink is now used
|
Good stuff! |
| s, err = filepath.EvalSymlinks(gopath.Join(absPath, file.Name())) | ||
| var sym_file os.FileInfo | ||
| sym_file, err = os.Stat(s) | ||
| fileChan <- NewLocalFile(gopath.Join(absPath, file.Name()), sym_file) |
There was a problem hiding this comment.
sym_file, please use symFile.
s, please use symInfo.
Instead of gopath.Join(absPath,...) twice create a variable say symAbsPath := gopath.Join(absPath, file.Name())
then you can use it in the EvalSymlinks as well as NewLocalFile calls
|
LGTM, merging. Thank you! |
list: traverse nested dir symlinks
|
In the course of trying to troubleshoot my continued problem with file duplication #137, I created some test folders containing every possible combination of nested symlinks. Everything works fine if I have: It breaks if I have have: e.g. the symlink is created with drive version 0.1.8 |
|
@brandoncurtis thank you for the detailed debugging and experiments. Sounds plausible but I cannot seem to reproduce this e.g |
Addresses issue #80 and fixes commit 7f7dea5. The proper path of the symlink is now used