-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working with symlinks #80
Comments
It is, symlinks should not matter. $ cd ~/my_drive
$ ln -s ~/Desktop/test.txt
$ drive push test.txt In fact one of the push methods $ cd ~/my_drive/tests
$ drive push -m ~/Desktop/content ~/angstrom . If this persists would you mind giving drive version, OS, go version, as well as a screenshot of a test? |
It doesn't automatically follow symlinks though:
The result is a file in Drive called somefolder. It's a 0 byte binary file where it should be a folder containing file. |
Your example works for me too. The problem is actually when there is a symlink inside a subdirectory. In my case:
This results in the problem I described. I also tried
|
It would be great if you could give me information like the version of drive, OS and any other information, as previously requested. |
Sorry forgot to add it's drive 0.1.1 (from Github) on Linux Mint 17.1 x64. |
Alright, I'll look at it when I get home in about 10 hours. |
Okay, so ReadDir when given a directory does not resolve the symlinks if they are directories. You can try to reproduce this even on your system by doing $ mkdir -p a/b
$ mkdir -p ~/Desktop/z1/z2 && ls ~ > ~/Desktop/z1/z2/listing.txt
$ ln -s ~/Desktop/z1/z2 a/b
$ ls -R a # Should print only z2 and nothing inside it This to me is on the OS and not a bug on drive's part. Of course I could try to mitigate this but what happens when the next user who expects system dependent behaviour? |
You know what, never mind, I'll just include this in the README with caution to the user. |
Please pull from master, and try again. |
Addresses issue odeke-em#80 and fixes commit 7f7dea5. The proper path of the symlink is now used
Is it possible to push a symlink? Now it results in pushing an empty file.
The text was updated successfully, but these errors were encountered: