Remove dealing with descr and url files #6253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpamAdminRepoUpgrade: deal locally with descr/url files OpamAdminCommand: adapt checks whether url is present, and whether the opam file version is good
kit-ty-kate
reviewed
Oct 21, 2024
Co-authored-by: Kate <kit-ty-kate@outlook.com>
kit-ty-kate
force-pushed
the
remove-descr-url
branch
from
d304842
to
fc6454e
Compare
hannesm
force-pushed
the
remove-descr-url
branch
from
6d2e879
to
abe2fc4
Compare
hannesm
force-pushed
the
remove-descr-url
branch
from
abe2fc4
to
adb134e
Compare
|
there's quite some tests that fail now... I'm not sure whether this is related (likely it is) -- but also not sure whether updating the tests is preferred, or whether some bits of the code should be re-instantiated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have been deprecated since quite some time. I suspect this PR could go further, and remove the OpamFile.DescrIO module - but I failed to understand what to replace it with.
Please let me know whether this direction is the right one. I'm especially unsure whether there need to be more guards checking that url / descr do not exist.