-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add curl to the list of required cygwin packages to avoid issues with Windows' curl #6142
base: master
Are you sure you want to change the base?
Conversation
f019fb0
to
489ddc5
Compare
I think this is probably the way it'll have to go - two things which ought to be checked:
|
I've tried this and it's not pulled by
|
The last commit makes |
Note for reviewers: the diff is easier to read with the "Hide whitespace" option on. |
Thanks, @kit-ty-kate! I think the additional code for |
ah interesting, so should we just wait for Microsoft to fix this? I'm not sure how frequent are their updates though |
I don't know what the policy (or if it's published), but the current version installed is from May 2024, so it's at least happened once recently! The problem with "forcing" Cygwin's I just had a closer look at the Lines 1504 to 1516 in 6effccc
would want altering so that even with an internal installation it does the depext check at: Line 1626 in 6effccc
would automatically add the new packages - i.e. doing it in |
It does but i personally view it as a feature. As far as i know we currently have no way to update cygwin itself except by running the setup.exe binary itself and give all the correct paths to it, or by installing a depext. I feel like having |
Yes, indeed - I think re-running setup for the internal Cygwin installation is a good idea .. but, as you note, it needs |
Converted to draft as i think the original issue is better fixed by #6168. However i'm keeping this around as we might need want to think about the upgrade mechanism again at some point |
Fixes #6120
Backported in opam 2.2 by #6143