Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Args: stop hiding the Windows specific arguments of opam init on non-Windows platforms #6003

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jun 7, 2024

They are now in the manpage and available in non-windows cli, but error.

@rjbou rjbou added this to the 2.2.0~beta3 milestone Jun 7, 2024
@rjbou rjbou requested review from kit-ty-kate and dra27 June 7, 2024 11:45
@rjbou
Copy link
Collaborator Author

rjbou commented Jun 7, 2024

Current status : I kept --no-cygwin-setup and --no-git-location non windows specific, as they are no-op in non windows. I allows then to not fails for shared script, in any.

@kit-ty-kate kit-ty-kate force-pushed the argtools-windows branch 2 times, most recently from fff3c72 to e23cec6 Compare June 7, 2024 12:23
@kit-ty-kate kit-ty-kate changed the title Args: no more hide Windows-only options Args: stop hidding the Windows specific arguments of opam init on non-Windows platforms Jun 7, 2024
master_changes.md Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate changed the title Args: stop hidding the Windows specific arguments of opam init on non-Windows platforms Args: stop hiding the Windows specific arguments of opam init on non-Windows platforms Jun 7, 2024
…indows platforms

--no flags as --no-cygwin-setup and --no-git-location remain available but are no-op
De-emphasise options slightly when you're actually on the platform in
question - as with CLI version.
@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit eff5a2a into ocaml:master Jun 7, 2024
29 checks passed
@dra27 dra27 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants