Fix incorrect package installed state written on error #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the 2.2 project as I haven't yet determined if this is a regression or long-standing. |
kit-ty-kate
reviewed
May 3, 2024
rjbou
reviewed
Aug 5, 2024
Comment on lines
+512
to
+521
| ### opam update | ||
| [NOTE] ongoing.dev has previously been updated with --working-dir, not resetting unless explicitly selected | ||
|
|
||
| <><> Updating package repositories ><><><><><><><><><><><><><><><><><><><><><><> | ||
| [second] no changes from file://${BASEDIR}/REPO2 | ||
| [default] synchronised from file://${BASEDIR}/REPO | ||
|
|
||
| <><> Synchronising development packages <><><><><><><><><><><><><><><><><><><><> | ||
| [quux.dev5] synchronised (no changes) | ||
| Now run 'opam upgrade' to apply any package updates. |
There was a problem hiding this comment.
Is this opam update output needed?
There was a problem hiding this comment.
I think currently yes but we could remove it if the new version of d-foo.6 was introduced using <pkg:d-foo.6> instead of <REPO/...>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package needs to be rebuilt because of upstream changes, an error in the rebuild causes a cache indicating that it's installed to be written. Something appears to be wrong in
OpamClient.parallel_apply, but I haven't got to the bottom of exactly what.What I have written is a test! Spotted while debugging #5921 - because errors during fetch also trigger this. Note in the commit history that erasing
.opam-switch/packages/cachecauses opam to do the right thing on the second upgrade.