Fish integration: nitpicking #5866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase on top of master? the two tests are conflicting |
ElectreAAS
force-pushed
the
slightly-bigger-fish
branch
from
9c5ab81
to
eda4c4d
Compare
|
Done :) |
|
LGTM, could you update the changelog (master_changes.md) with this change? If you don't know what to put we can do it for you. |
rjbou
approved these changes
Mar 5, 2024
ElectreAAS
force-pushed
the
slightly-bigger-fish
branch
from
f712a06
to
1cb9ba2
Compare
kit-ty-kate
approved these changes
Mar 7, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the third and last off-shoot of #5802, containing the only bugfix in the previous PR: this change
isatty -> status is-interactive.