init: on windows, fix handling of 'git-location' when defined in init config #5848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
commented
Feb 16, 2024
src/client/opamClient.ml
Outdated
Comment on lines
756
to
757
| "As '--no-git-location' is given in argument, ignoring field \ | ||
| 'git-location' in init config file"; |
There was a problem hiding this comment.
Needs proof reading for clarity, understanding.
src/client/opamClient.ml
Outdated
Comment on lines
762
to
763
| "Git location defined in init config file (opamrc, %s) and via CLI \ | ||
| ('--git-location' option, %s). Keeping last one." |
There was a problem hiding this comment.
Needs proof reading for clarity, understaanding.
kit-ty-kate
approved these changes
Feb 19, 2024
… config file (opamrc given via commandline, or present on users defaults)
kit-ty-kate
force-pushed
the
git-location-init
branch
from
170d639
to
2db04ac
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5845
If
--git-locationis given andgit-locationis defined, priority goes to the one defined via CLI. Same with--no-git-location, it overridesgit-locationdefinition in config file.