Quote all the paths to OPAMROOT when creating the init scripts on Unix

[kit-ty-kate]

Fixes #5804

I personally think keeping the Windows style paths on Windows when using cygwin shell is fine, however none of the paths were previously quoted which is a big issue and the reason why the user in #5804 looked in the file in the first place as such command will always fail on Windows.

On cmd and powershell double quoting is apparently enough to make sure the string can't escape its context (?) (e.g. " and $ are not valid file characters)

[rjbou]

The code changes are good for me!
It would be better to have in the shell files unix-like paths (transformed via cygpath) instead of windows ones, even if it is understandable by cygwin.

[rjbou]

Updated accordingly, it then needs another review :)

[kit-ty-kate]

Why did you remove the calls to OpamStd.Env.escape_single_quotes ? Is the cygpath function doing this job instead?

[rjbou]

There is no need to escape them for printing, as cygpath will output the path with slashes. And cygpath function don't need to have a single escaped input.

[kit-ty-kate]

what happens on unix though? (when cygpath is not present)

[rjbou]

tested on cygwin shell

------------------
./opam/opam-init/init.cmd
------------------
if exist "C:\Users\opam\.opam\opam-init\variables.cmd" call "C:\Users\opam\.opam\opam-init\variables.cmd" >NUL 2>NUL

------------------
./opam/opam-init/init.csh
------------------
if ( $?prompt ) then
  if ( -f '/cygdrive/c/Users/opam/.opam/opam-init/env_hook.csh' ) source '/cygdrive/c/Users/opam/.opam/opam-init/env_hook.csh' >& /dev/null
endif

if ( -f '/cygdrive/c/Users/opam/.opam/opam-init/variables.csh' ) source '/cygdrive/c/Users/opam/.opam/opam-init/variables.csh' >& /dev/null

------------------
./opam/opam-init/init.fish
------------------
if isatty
  source '/cygdrive/c/Users/opam/.opam/opam-init/env_hook.fish' > /dev/null 2> /dev/null; or true
end

source '/cygdrive/c/Users/opam/.opam/opam-init/variables.fish' > /dev/null 2> /dev/null; or true

------------------
./opam/opam-init/init.ps1
------------------
. "C:\Users\opam\.opam\opam-init\variables.ps1" *> $null

------------------
./opam/opam-init/init.sh
------------------
if [ -t 0 ]; then
  test -r '/cygdrive/c/Users/opam/.opam/opam-init/complete.sh' && . '/cygdrive/c/Users/opam/.opam/opam-init/complete.sh' > /dev/null 2> /dev/null || true

  test -r '/cygdrive/c/Users/opam/.opam/opam-init/env_hook.sh' && . '/cygdrive/c/Users/opam/.opam/opam-init/env_hook.sh' > /dev/null 2> /dev/null || true
fi

test -r '/cygdrive/c/Users/opam/.opam/opam-init/variables.sh' && . '/cygdrive/c/Users/opam/.opam/opam-init/variables.sh' > /dev/null 2> /dev/null || true

------------------
./opam/opam-init/init.zsh
------------------
if [[ -o interactive ]]; then
  [[ ! -r '/cygdrive/c/Users/opam/.opam/opam-init/complete.zsh' ]] || source '/cygdrive/c/Users/opam/.opam/opam-init/complete.zsh' > /dev/null 2> /dev/null

  [[ ! -r '/cygdrive/c/Users/opam/.opam/opam-init/env_hook.zsh' ]] || source '/cygdrive/c/Users/opam/.opam/opam-init/env_hook.zsh' > /dev/null 2> /dev/null
fi

[[ ! -r '/cygdrive/c/Users/opam/.opam/opam-init/variables.sh' ]] || source '/cygdrive/c/Users/opam/.opam/opam-init/variables.sh' > /dev/null 2> /dev/null

reminds me of #5036, that tried to add init scripts tests

[rjbou]

what happens on unix though? (when cygpath is not present)

get_cygpath_path_transform is a no-op (identity)

[kit-ty-kate]

what happens on unix though? (when cygpath is not present)

get_cygpath_path_transform is a no-op (identity)

in that case this is a problem and OpamStd.Env.escape_single_quotes is still required

[rjbou]

Oh, i didn't see that it was an addition for the quoting. Yes, it is needed!

[rjbou]

Updated

[rjbou]

thanks!

[rjbou]

Bench tests failing as service was on available.