Disable Windows critical error handler #5828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this suppresses the "execution cannot proceed because X.dll was not found" dialog, instead returning an exit code. Calling this at program startup is already recommended best practice for Windows applications.
kit-ty-kate
approved these changes
Feb 12, 2024
rjbou
approved these changes
Feb 12, 2024
|
Let's get it merged before that screenshot of the dialog grows any further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the WIndows loader cannot find DLLs, the default, very very legacy behaviour is to display a dialog such as this:
This dialog is problematic, as it's part of the loader, so the application itself is not able to handle this itself. It's doubly problematic for us, as it's blocking.
The convention is that calling applications are expected to disable this error handler. New processes inherit this setting, which causes the loader to suppress the dialog box and instead return an exit code. This is documented best practice (see the notes for
SEM_FAILCRITICALERRORSin SetErrorMode on MSDN).