[API] Make the ?lock_kind parameters non-optional to avoid breaking the library users after they upgrade their opam root #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
commented
Mar 21, 2023
kit-ty-kate
commented
Mar 21, 2023
rjbou
reviewed
Mar 21, 2023
This was referenced Mar 21, 2023
kit-ty-kate
force-pushed
the
explicit-lock-kind
branch
3 times, most recently
from
ac4a7d6 to
0472d10
Compare
kit-ty-kate
changed the title
rjbou
approved these changes
Feb 19, 2025
rjbou
force-pushed
the
explicit-lock-kind
branch
from
e301b02 to
d1c4241
Compare
…he library users after they upgrade their opam root
kit-ty-kate
force-pushed
the
explicit-lock-kind
branch
from
d1c4241 to
0308e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5487
The current code shows issues with our internal uses of such functions, opening as a draft for now and I will point out where the issues are.