Use OCaml code to copy/move/remove directories instead of unix commands #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AltGr
reviewed
Dec 10, 2021
src/core/opamSystem.ml
Outdated
| copy_dir src dst | ||
| | {Unix.st_kind = Unix.S_LNK; _} -> | ||
| let src = Unix.readlink src in | ||
| link src dst |
There was a problem hiding this comment.
src may need rewriting if relative to the srcdir, depending on whether the target is within the dir or not ?
There was a problem hiding this comment.
the link doesn't resolve to an existing id
AltGr
reviewed
Feb 11, 2022
kit-ty-kate
force-pushed
the
unix-cmd-to-unix-calls
branch
from
aa02169 to
b42e336
Compare
kit-ty-kate
force-pushed
the
unix-cmd-to-unix-calls
branch
from
7f3c3cf to
a830fe5
Compare
rjbou
force-pushed
the
unix-cmd-to-unix-calls
branch
from
a830fe5 to
82ee215
Compare
rjbou
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1073 for good.
This also makes opam slightly more portable and not so much reliant on external processes (see e.g. #3217)
Warning for testers: This is untested code touching the file system. Only test this in a sandboxed environment.