Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --columns advertised options #4322

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Fix --columns advertised options #4322

merged 1 commit into from
Aug 24, 2020

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Aug 19, 2020

#3931 allows <field> to refer directly to a raw opam field and so added an entry to OpamListCommand.field_names. This list is also used for the --columns argument to opam list and opam admin list which still requires the trailing colon at all times.

This PR removes the spurious <field> from the help for --columns - this is correct (I think) since --raw can't be used here as --columns is a list of fields.

@dra27 dra27 added this to the 2.1.0~beta milestone Aug 19, 2020
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AltGr AltGr merged commit dd272d9 into ocaml:master Aug 24, 2020
@dra27 dra27 deleted the raw-field branch September 7, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants