On init, check and propose to disable sandboxing if tool present & not working (docker, chroot, WLS1, etc.) #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
reviewed
Jul 27, 2020
|
ping @mato? |
AltGr
reviewed
Aug 24, 2020
AltGr
reviewed
Aug 24, 2020
src/client/opamClient.ml
Outdated
| @@ -752,6 +752,62 @@ let init_checks ?(hard_fail_exn=true) init_config = | |||
| if hard_fail && hard_fail_exn then OpamStd.Sys.exit_because `Configuration_error | |||
| else not (soft_fail || hard_fail) | |||
|
|
|||
| (* Check sandboxing script call. If it errors or unattended output, disable | |||
There was a problem hiding this comment.
Not sure I would have chosen this module for this, since it's at the moment concerned with package-handling stuff and the switch state... but I don't have a much better proposition ?
There was a problem hiding this comment.
moved to OpamAuxCommand
src/client/opamClient.ml
Outdated
| OpamSysPoll.variables >>= Lazy.force) | ||
| in | ||
| match OpamFilter.commands env sdbx_wrappers with | ||
| | [] -> config |
There was a problem hiding this comment.
Too bad we can't use the code of OpamAction here :/
There was a problem hiding this comment.
Added OpamEnv.hook_env
…don't fail on simple command), and propose to disable it if so
AltGr
added a commit
to OCamlPro/opam
that referenced
this pull request
Sep 2, 2020
See ocaml#4284 I was getting: ``` % OPAMROOT=/tmp/egex opam init [NOTE] Will configure from built-in defaults. [ERROR] Sandboxing is not working on your platform debian: "/tmp/egex/opam-init/hooks/sandbox.sh": command not found. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check is done by calling the sandbox script with
sandbox <action> sh -c "echo SUCCESS >/tmp/t && cat /tmp/t", and checking that stdout isSUCCESS.Disabling is done by removing from global config sandboxing wrappers, default ones, defined in
OpamInitDefaults.sandbox_wrappers.