Skip to content

Commit

Permalink
--with-private-runtime should default to shared
Browse files Browse the repository at this point in the history
If opam is configured with --with-private-runtime, then shared linking
should be assumed by default.
  • Loading branch information
dra27 committed Jun 2, 2024
1 parent a65af70 commit 67fae1c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion configure

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ AS_CASE([$TARGET],
],
[*-*-mingw32*],[
support_static=yes
default_static=yes
AS_IF([test "x${with_private_runtime}" = "xno"],[default_static=yes])
# NOTE: On Windows, the Windows specific dlls should stay dynamic for security reasons
# NOTE: -l:libstdc++.a is necessary (vs. -lstdc++) as flexlink will use libstdc++.dll.a
# which still depends on the DLL at runtime instead of libstdc++.a (that looks like a bug in flexlink)
Expand Down

0 comments on commit 67fae1c

Please sign in to comment.