--with-private-runtime should default to shared

If opam is configured with --with-private-runtime, then shared linking should be assumed by default.
ocaml · Jun 4, 2024 · 410a91d · 410a91d
1 parent 1bedd3f
commit 410a91d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/configure b/configure
diff --git a/configure.ac b/configure.ac
@@ -346,7 +346,7 @@ AS_CASE([$TARGET],
   ],
   [*-*-mingw32*],[
     support_static=yes
-    default_static=yes
+    AS_IF([test "x${with_private_runtime}" = "xno"],[default_static=yes])
     # NOTE: On Windows, the Windows specific dlls should stay dynamic for security reasons
     # NOTE: -l:libstdc++.a is necessary (vs. -lstdc++) as flexlink will use libstdc++.dll.a
     # which still depends on the DLL at runtime instead of libstdc++.a (that looks like a bug in flexlink)