-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Package libbinaryen.117.0.0-b #28763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package libbinaryen.117.0.0-b #28763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
What's up with the version 117.0.0-b? Why not just use 117.0.1 or 117.1.0 instead? 🤔
Looking again at https://opam.ocaml.org/doc/Manual.html#Version-ordering
I can see that it should sort after 117.0.0 (but so should the other suggestions)
|
Hey @jmid! This package is meant to mirror versions of https://github.com/webassembly/binaryen. This change fixes some build issues for OCaml and ended up dropping support for 4.12. It's kind of a breaking change in that sense and made doing a 117.0.1 or 117.1.0 feel wrong for both semantic versioning reasons as well as matching upstream Binaryen version reasons, so we went with this instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
Initially I was wondering whether the slightly unconventional version name could cause problems later. Looking at the above opam manual page, a dash is however included as an example, so it should be OK to do so.
|
Why |
|
Hey @mseri, in my experience the letters seem to be about as common as numbers are for these out of band releases. Is the other part of your question different than what was discussed in the above conversation? |
|
There has also already been a release cut on npm for the esy version of the package, so it would be nice if we could have them both matching. https://www.npmjs.com/package/@grain/libbinaryen/v/117.0.0-b |
|
Sure, that's all right. It was mostly a curiosity and a clarification on the versioning |
libbinaryen.117.0.0-bLibbinaryen packaged for OCaml
libbinaryen v117.0.0-b
117.0.0-b (2025-10-22)
Features
🐫 Pull-request generated by opam-publish v2.4.0