Skip to content

Conversation

@ospencer
Copy link
Contributor

libbinaryen.117.0.0-b

Libbinaryen packaged for OCaml



libbinaryen v117.0.0-b

117.0.0-b (2025-10-22)

Features

  • Update libbinaryen v117 for esy@0.8.0 and ocaml 5 (#119)

🐫 Pull-request generated by opam-publish v2.4.0

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

What's up with the version 117.0.0-b? Why not just use 117.0.1 or 117.1.0 instead? 🤔
Looking again at https://opam.ocaml.org/doc/Manual.html#Version-ordering
I can see that it should sort after 117.0.0 (but so should the other suggestions)

@jmid jmid added the question label Oct 24, 2025
@ospencer
Copy link
Contributor Author

Hey @jmid! This package is meant to mirror versions of https://github.com/webassembly/binaryen. This change fixes some build issues for OCaml and ended up dropping support for 4.12. It's kind of a breaking change in that sense and made doing a 117.0.1 or 117.1.0 feel wrong for both semantic versioning reasons as well as matching upstream Binaryen version reasons, so we went with this instead.

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!
Initially I was wondering whether the slightly unconventional version name could cause problems later. Looking at the above opam manual page, a dash is however included as an example, so it should be OK to do so.

@mseri
Copy link
Member

mseri commented Oct 27, 2025

Why -b instead of a more common patch version -1? It is to keep numbers free for possible patch versions of 117.0.0?

@ospencer
Copy link
Contributor Author

Hey @mseri, in my experience the letters seem to be about as common as numbers are for these out of band releases. Is the other part of your question different than what was discussed in the above conversation?

@spotandjake
Copy link

There has also already been a release cut on npm for the esy version of the package, so it would be nice if we could have them both matching.

https://www.npmjs.com/package/@grain/libbinaryen/v/117.0.0-b

@mseri
Copy link
Member

mseri commented Oct 29, 2025

Sure, that's all right. It was mostly a curiosity and a clarification on the versioning

@mseri mseri merged commit e738f47 into ocaml:master Oct 29, 2025
1 of 3 checks passed
@jmid jmid mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants