-
Notifications
You must be signed in to change notification settings - Fork 1.2k
gen_js_api 1.1.* tests are not compatible with latest js_of_ocaml #28161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mseri
wants to merge
2
commits into
ocaml:master
Choose a base branch
from
mseri:js-of-ocaml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails with ``` -let (_ : string of_js) = Ojs.string_of_js -let (_ : string to_js) = Ojs.string_to_js -let (_ : int of_js) = Ojs.int_of_js -let (_ : int to_js) = Ojs.int_to_js -let (_ : bool of_js) = Ojs.bool_of_js -let (_ : bool to_js) = Ojs.bool_to_js -let (_ : float of_js) = Ojs.float_of_js -let (_ : float to_js) = Ojs.float_to_js -let (_ : Ojs.t of_js) = fun (x9 : Ojs.t) -> x9 -let (_ : Ojs.t to_js) = fun (x10 : Ojs.t) -> x10 -let (_ : (string * int) of_js) = +let _ = Ojs.string_of_js +let _ = Ojs.string_to_js +let _ = Ojs.int_of_js +let _ = Ojs.int_to_js +let _ = Ojs.bool_of_js +let _ = Ojs.bool_to_js +let _ = Ojs.float_of_js +let _ = Ojs.float_to_js +let _ = fun (x9 : Ojs.t) -> x9 +let _ = fun (x10 : Ojs.t) -> x10 +let _ = fun (x11 : Ojs.t) -> let x12 = x11 in ((Ojs.string_of_js (Ojs.array_get x12 0)), (Ojs.int_of_js (Ojs.array_get x12 1))) -let (_ : (string * int) to_js) = +let _ = fun (x13 : (string * int)) -> let (x14, x15) = x13 in let x16 = Ojs.array_make 2 in Ojs.array_set x16 0 (Ojs.string_to_js x14); Ojs.array_set x16 1 (Ojs.int_to_js x15); x16 ``` Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Seen on #28144 |
mseri
commented
Jul 14, 2025
mseri
commented
Jul 14, 2025
mseri
commented
Jul 14, 2025
mseri
commented
Jul 14, 2025
mseri
commented
Jul 14, 2025
mseri
commented
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails with