[new release] js_of_ocaml (8 packages) (6.1.1) #28144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: ## Bug fixes * Compiler: Fix shape loading (ocsigen/js_of_ocaml#2074)
|
same errors as #28135 |
Just to clarify, errors are unrelated, this is good to go. |
|
The gen_js_api seems due to a change in output. Are you sure we should not add an upper bound on the tests? |
We could probably disable the tests for problematic combination of ppxlib+gen_js_api. But id prefer not to delay this PR too much. |
|
I had the PR ready :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler from OCaml bytecode to JavaScript
CHANGES:
Bug fixes