-
Notifications
You must be signed in to change notification settings - Fork 86
Cleanup formatting #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cleanup formatting #799
Conversation
This is now failing because ocamlformat.yml github workflow we have doesn't set up special dune when doing configure. Why do we have it in a separate workflow file? |
91dbd03
to
428a910
Compare
@gretay-js not sure there is any particularly good reason it's in a separate file |
ok, maybe I can add it as an extra target in one of the existing builds. |
@gretay-js we can probably close this one I think ? |
@gretay-js ping |
I'll rebase and fix it up. |
Ping again on that one ? |
Change
make fmt
to usedune build @fmt --auto-promote
.I'm slightly worried about other consequences of vendoring
ocaml
: targets that aren't explicitly requested by toplevel dune file won't build or install any more, according to the dune docs), but nothing is missing from the install directory.