Format dune files #789
Closed
Format dune files #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking only for the paths that are formatted. The stronger check is reasonable and makes it easier to add new paths.
gretay-js
requested review from
mshinwell,
stedolan,
xclerc,
lukemaurer,
poechsel,
lthls,
chambart and
Gbury
as code owners
|
I'll rework this to use "dune build @fmt" directly. |
|
Superceded by #799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add target
make fmt-dune-filesand add it as a dependency ofmake fmttarget.Uses
dune format-dune-file(which formats a single file and does not work in place) and thenmv.This PR also includes separate commit to reformat all existing 65 dune files in the repo, including the once under
ocaml/.It should be easy to exclude
ocaml/from the rule.There was a change in permissions in file the main dune file (and some others) from 755 to 644.