Add Mode.Crossing
#3639
Merged
Add Mode.Crossing
#3639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riaqn
commented
Feb 28, 2025
lukemaurer
reviewed
Mar 12, 2025
that performance tuning is done, btw |
lukemaurer
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reduced version of #2527 so we can merge it sooner.
This PR adds
Mode.Crossing.t, which describes the mode crossing capability of a type. The main benefit is to have a single place describing and implementing mode crossing, which involves subtleties around adjunction and specific mode system details.Jkind modal bounds are not touched since @glittershark is doing some performance tuning that are incompatible with this PR. Conversion from jkind modal bounds are provided. In the future we will do similiar performance tuning for
Mode.Crossing.tso they can be used directly in jkind.Please review by commits.