New mode crossing representation #2527
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riaqn
force-pushed
the
general-mode-crossing
branch
from
b259e19 to
c31323f
Compare
|
What does this allow? I looked for the testsuite changes, but didn't spot the interesting bit. |
riaqn
force-pushed
the
general-mode-crossing
branch
from
c31323f to
8bae04e
Compare
Merged
|
superseded by #3639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #2344, because we need to support calculating the mode crossing of "a @@ m" where
mis modality.This PR refactors the mode-crossing logic, without any observable changes. Future PRs based on this will enable more mode crossing.