Skip to content

Commit

Permalink
chore(breaking): use Node 10 as compile target (react-native-communit…
Browse files Browse the repository at this point in the history
…y#1072)

* fix: Update to Node.js LTS 10

Node 8 is out of the support

* bump node to 10 for package and Babel

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
  • Loading branch information
wtrocki and thymikee authored Sep 17, 2020
1 parent 88402ca commit 1bd6552
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
14 changes: 9 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ defaults: &defaults
working_directory: ~/react-native-cli

executors:
node8:
node10:
<<: *defaults
docker:
- image: circleci/node:8
- image: circleci/node:dubnium
nodelts:
<<: *defaults
docker:
Expand Down Expand Up @@ -68,17 +68,21 @@ commands:

jobs:
setup:
executor: node8
executor: node10
steps:
- install-dependencies
lint:
executor: node8
executor: node10
steps:
- run-lint
unit-tests:
cocoa-pods:
executor: noderuby
steps:
- install-cocoapods
- run-cocoa-pods-tests
unit-tests:
executor: node10
steps:
- run-unit-tests
e2e-tests:
executor: reactnative
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
[
require.resolve('@babel/preset-env'),
{
targets: {node: '8.3'},
targets: {node: '10'},
useBuiltIns: 'entry',
corejs: '2.x',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
],
"engineStrict": true,
"engines": {
"node": ">=8.3"
"node": ">=10"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit 1bd6552

Please sign in to comment.