Repository navigation
docs(console): correct the ResizablePanelGroup prop and declare every fragment block under apps/console/docs - #7425
Merged
os-project-manager merged 2 commits intoSep 3, 2026
Conversation
…ragment blocks (objectui#7282) `UI_IMPROVEMENT_PROPOSAL.md` section 3.1 taught `<ResizablePanelGroup direction="horizontal">`. The exported component takes `orientation` (`packages/components/src/ui/resizable.tsx:44`, pinned by `resizable-orientation.test.tsx` and used in-tree at `navigation-overlay.tsx:520`), so a reader who copied the guide got a TS2322 on its first prop. The other ten red `ts` / `tsx` blocks under `apps/console/docs/**` are excerpt fragments, not defects. Each now carries `check-doc-snippet-types.mjs`'s per-block fragment declaration with a written reason naming the identifiers the excerpt leaves to its host. No `UNGATED_DOCS` entry was added: the 2026-09-02 ruling on objectui#6600 rejects whole-file exemptions. Re-derived census on this tree: 14 ts/tsx blocks, 11 red (2 syntax, 9 semantic) before this change, 0 after. The three blocks left undeclared are the design-token lists in "Visual Design Specs", which compile as labelled statements and so are not fragments. This is objectui#6600's step 1. No gate script is touched and no gate root moves; that is #6600's step 2, which this unblocks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EMrWaQw3XS5DxTHxp4yRyC
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
…(objectui#7282) The changeset cited `navigation-overlay.tsx:520` for the in-tree `ResizablePanelGroup` call site and framed it as drift from the card's `:519`. There was no drift — the card was right. Measured with `git grep -n` at the base this branch was cut from: bf244f4:packages/components/src/custom/navigation-overlay.tsx:519: <ResizablePanelGroup orientation="horizontal" ...> `:520` is the child `ResizablePanel`, not the group. The original figure came from counting off a `sed` line range by hand instead of asking `grep -n`, which is the whole reason to ask `grep -n`. This also corrects the same wrong reference in the message of 3b067b9, which cannot be amended now that the branch is pushed (no force-push). `resizable.tsx:44` and `resizable-orientation.test.tsx:52` were verified exact and are unchanged. No documentation content, no fragment marker, no census figure moves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EMrWaQw3XS5DxTHxp4yRyC
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
os-project-manager
marked this pull request as ready for review
September 3, 2026 01:35
os-project-manager
deleted the
claude/issue-7282-console-docs-fragment-markers
branch
September 3, 2026 01:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7282
Step 1 of maintainer ruling D on #6600 (decision batch #8, 2026-09-02, verbatim 「同意」): fix the content first, then move the documentation gates' roots. No gate script is touched and no gate root moves — that is #6600's step 2, which this unblocks.
Step 1 — is
UI_IMPROVEMENT_PROPOSAL.mdstill live?Verdict: live. The fix branch was taken, not retirement. The evidence, recorded either way as the dispatch requires:
For liveness
apps/console/README.md:134links it from the app's "Documentation" table — one of the four documents listed there, alongside the repo ROADMAP and twocontent/docsguides.packages/app-shell/src/views/MetadataInspector.tsx(useMetadataInspector,MetadataPanel), and the console consumes it atapps/console/src/preview-gallery.tsx:51,110viagetMetadataInspector.ResizablePanelGroupis a real export of@object-ui/components(packages/components/src/ui/resizable.tsx:44), pinned bypackages/components/src/__tests__/resizable-orientation.test.tsx:52and called in-tree atpackages/components/src/custom/navigation-overlay.tsx:519.apps/*/docs/**intocheck-doc-links, andscripts/__tests__/check-doc-links.test.ts:1507names this exact path when pinning that.Against (recorded, and not decisive)
366775d42(copilot-swe-agent[bot], PR Simplify console list page: design mode toggle + modernized metadata inspector #444, merged as65901a5ed) and not modified since — the only commit that touches it.git log -- paththere attributes the file to835a2cebe(a repo-wide lint-directive fix, PR fix(lint): correctly place two misplaced eslint-disable-next-line directives #5978), which in full history does not touch it at all. This branch's figure comes from an unshallowed clone.apps/console/src/components/MetadataInspector.tsx, no longer exists — it moved topackages/app-shell/src/views/.Neither strand is decisive: an unrevised design proposal is not thereby dead, its subject is demonstrably live, and it is linked from the app's own documentation index. Retirement would have deleted a linked document to close a one-word prop defect. Per the dispatch, anything short of decisive goes to the fix branch.
Step 1 — the defect
Section 3.1 taught
ResizablePanelGroupwith adirection="horizontal"prop. The exported component takesorientation. A reader copying the block gotTS2322on its first prop. Corrected in place; nothing else in that block changed.Step 2 — fragment markers
Ten blocks now carry
check-doc-snippet-types.mjs's per-blockdoc-snippet: fragmentdeclaration (HTML-comment spelling, the one the gate'sFRAGMENT_MARKER_EXAMPLESgives for.md), each with a written reason naming the identifiers the excerpt leaves to its host. NoUNGATED_DOCSentry was added — the ruling rejects whole-file exemptions.Re-derived census (the card's numbers were measured earlier; these are this tree's)
Measured on
bf244f400with the gate's ownscanFencesandcompileSnippets:ts/tsxblocks underapps/*/docs/**TS2322)Exactly matching the card's 14/11. Per document:
UI_IMPROVEMENT_PROPOSAL.md12 blocks (9 red),error-tracking.md2 blocks (2 red),deployment.md0 blocks.The three already-green blocks are deliberately left undeclared. They are the design-token lists under "Visual Design Specs" (
background:,title:,panel:…), which parse as labelled statements and compile clean. Declaring them would assert they cannot compile — false — and would remove three blocks from real semantic coverage. See "Out of scope" below.The card's three source references were verified exact on the base this branch was cut from:
resizable.tsx:44,resizable-orientation.test.tsx:52andnavigation-overlay.tsx:519.Acceptance — the ruling's own criterion
A scratch harness imports the gate's exported functions and replays
analyze()'s glue overapps/*/docs/**instead ofcontent/docs. Nothing in the repo is modified. All four controls held:check:doc-snippetsreports 0 failed for this tree. That is #6600 step 2's precondition.Reverse verification
Predicted direction stated before running: red on both legs. The fix was committed first, so each leg restores from
HEAD; each mutation was proven on disk by counting the injected and removed text, and each restore proven by hash equality with theHEADblob plus an emptygit diff HEAD.orientation=back todirection=): red, 1 failed,TS2322on that block. The green is caused by this change.orientationX=): red, 1 failed, and TypeScript's own diagnostic ends "Did you mean 'orientation'?". The block's props are genuinely excess-checked, so acceptingorientationis a real judgement rather than a widenedany.HEAD.Gates run — union at
3b067b9b0, clean treeEach exit code captured before any pipe; each verdict quoted from the gate's own line.
pnpm docs:check-linkspnpm check:doc-snippetspnpm check:doc-typespnpm check:doc-fencespnpm check:control-bytescheck-changeset-presence.mjscheck-changeset-no-major.mjsmajorbump.apps/*/docsruncheck:doc-snippetsfirst returned exit 2 —PRECONDITION NOT MET, the gate's "could not run" code, not a documents verdict. Its own--build-filterclosure (25 packages) was built and it was re-run; the 0 above is that run.Follow-up commit
56fab342echanges two tokens of changeset prose and nothing else (git diff --stat 3b067b9b0 HEAD= 1 file, 1 insertion, 1 deletion). At the reviewer's direction the full union was not re-run for it;pnpm check:control-bytes(exit 0) andcheck-changeset-presence.mjs(exit 0) were, on the new head.pnpm lintis a repo-wide scan CI owns. The narrowing here is a measurement, not a skip: eslint's own config resolution reports all three changed files asFile ignored because no matching configuration was supplied(0 errors,--format json), the flat config carries no.mdmatcher, and the diff adds no config, nofilespattern and no source file — so no untouched file's verdict can move.Step 3 — changeset
Empty-frontmatter form, declaring "no release".
apps/consoleisprivate: true. It is not —@object-ui/consolehas noprivatekey and is a published member of the 40-packagefixedgroup at17.6.0. The declaration instead rests on a verified fact:apps/console/docs/**is not in the package'sfiles(dist,plugin.ts,plugin.js,plugin.d.ts,README.md), so no published artifact moves.check-changeset-presence.mjsagrees independently — it reports no changeset owed for this range.Out of scope — declined, not done
background: "bg-background"inside atsxfence compiles only because it parses as a labelled statement — green about nothing. The honest repair is the fence language, which is acheck:doc-fencesquestion about document shape rather than this card's defect class, andcheck:doc-fencesis currently green on them. Reported rather than changed, as finding(docs): threetsxfences in apps/console/docs are design-token lists that compile only as labelled statements — the snippet gate will be green about nothing once #6600 moves its roots #7426.apps/console/src/components/MetadataInspector.tsx, now underpackages/app-shell/src/views/). Rewriting a design proposal's prose is not this card's scope; recorded here so the next reader of that file has it.🤖 Generated with Claude Code
https://claude.ai/code/session_01EMrWaQw3XS5DxTHxp4yRyC