Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/12184-timezone-prompt-module-rename.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@object-ui/console': patch
---

The console builds again on a case-insensitive filesystem, which is macOS's default (objectui#12184). Two modules in the console's settings pages, the workspace-timezone prompt dialog and the logic behind it, had paths that differed only in case once the extension was dropped. TypeScript tries `.ts` before `.tsx`, so on such a filesystem the dialog's import resolved to the logic module and `tsc` failed. The logic module is now `workspaceTimezonePromptLogic.ts`. What the prompt does, and every i18n key it reads, stays as it was.
2 changes: 1 addition & 1 deletion apps/console/src/pages/auth/SetupPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
Label,
} from '@object-ui/components';
import { withConsoleBase } from '../../utils/consoleBase';
import { browserTimeZone } from '../settings/workspaceTimezonePrompt';
import { browserTimeZone } from '../settings/workspaceTimezonePromptLogic';

const AUTH_BASE = `${import.meta.env.VITE_SERVER_URL || ''}/api/v1/auth`;

Expand Down
4 changes: 2 additions & 2 deletions apps/console/src/pages/settings/WorkspaceTimezonePrompt.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* Mounted once, in the console's app shell (`AppContent`), inside the
* `MePermissionsProvider` that shell already mounts: that provider is what
* answers which capabilities this session holds. When to ask, and what to
* offer, is decided in `workspaceTimezonePrompt.ts`; this file is the dialog.
* offer, is decided in `workspaceTimezonePromptLogic.ts`; this file is the dialog.
*
* Both halves of the write are the Settings page's own:
*
Expand Down Expand Up @@ -54,7 +54,7 @@ import {
promptRecordKey,
wasAsked,
type TimezoneOffer,
} from './workspaceTimezonePrompt';
} from './workspaceTimezonePromptLogic';

export function WorkspaceTimezonePrompt() {
const { t } = useObjectTranslation();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ import {
isAdmissibleZone,
mayWrite,
promptRecordKey,
} from '../workspaceTimezonePrompt';
} from '../workspaceTimezonePromptLogic';
import type { Specifier } from '../types';

const BROWSER_ZONE = 'Asia/Kolkata';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ const DECLARED: Exemption[] = [
'formatted and no face is rendered.',
},
{
file: 'apps/console/src/pages/settings/workspaceTimezonePrompt.ts',
file: 'apps/console/src/pages/settings/workspaceTimezonePromptLogic.ts',
expression: 'const zone = Intl.DateTimeFormat().resolvedOptions().timeZone;',
count: 1,
verdict: 'not applicable',
Expand Down
Loading