Skip to content

fix(console): rename the timezone-prompt logic module so no module stem collides by case (objectui#12184) - #12196

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12184-timezone-prompt-module-rename
Oct 12, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12184-timezone-prompt-module-rename

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12184

Clause-②: no

What and why

apps/console/src/pages/settings/ held two modules whose extensionless stems differ only in case: WorkspaceTimezonePrompt.tsx (the dialog) and workspaceTimezonePrompt.ts (its logic), both from objectui#11758. TypeScript tries .ts before .tsx, so on a case-insensitive filesystem (macOS APFS by default) the import ./pages/settings/WorkspaceTimezonePrompt landed on the logic file and tsc failed. Linux CI is case-sensitive and stayed green.

As triage 6118599573 directed, the logic module is renamed to workspaceTimezonePromptLogic.ts with git mv (similarity 100%, content byte-identical), and its readers follow. No behaviour, export or i18n key changes. The optional case-collision CI check is not taken: triage ruled that a new gate defaults to no.

Readers updated

Measured with git grep -n workspaceTimezonePrompt on base 26b0bd2:

  • WorkspaceTimezonePrompt.tsx: the import of the logic module, and the doc comment that names the file ("When to ask, and what to offer, is decided in ...").
  • __tests__/WorkspaceTimezonePrompt.test.tsx: the import of browserTimeZone, isAdmissibleZone, mayWrite and promptRecordKey.
  • pages/auth/SetupPage.tsx: the import of browserTimeZone.
  • packages/i18n/src/__tests__/machineLocaleCensus-9909.test.ts: the declared-exemption row for const zone = Intl.DateTimeFormat().resolvedOptions().timeZone; names the file by path. Only its file changes; expression, count, verdict and reason stay. The card does not list this reader.

The grep's other hits are i18n key names: console.workspaceTimezonePrompt.* in the ten locale packs, the dialog's t() calls, and the pending changeset 11758-workspace-timezone-prompt.md. They are keys, not paths, and stay unchanged. A re-read of main before opening this PR found no new reader.

The stem pin (recorded here, not a gate)

Triage's pin, git ls-files apps/console | sort -f | uniq -di, already prints nothing on main, because the two paths differ in extension as well as case. It cannot fail. The pin set by the claim 6119202194 strips the extension first:

git ls-files | sed -E 's/\.(d\.ts|tsx|ts|jsx|js|mjs|cjs|mts|cts)$//' | sort -f | uniq -di
  • Before, on origin/main 26b0bd2: exactly one line, apps/console/src/pages/settings/WorkspaceTimezonePrompt.
  • After, on this branch's head 5a2a86c: no output (0 lines).
  • Control, same run: the same pipeline over git ls-tree -r --name-only 26b0bd2 still prints that one line. So the empty answer comes from the rename, not from a broken pipeline.

What this PR does not claim

It does not claim a macOS run. The failure needs a case-insensitive filesystem, and this change was verified on Linux. The evidence that the collision is gone is the pin above plus type-check for @object-ui/console passing. The macOS reading is the card's own: the reporter measured the same rename on macOS.

Verification, at head 5a2a86c

  • ① turbo run build --filter='@object-ui/console^...' --concurrency=2, through the verify lock: Tasks: 34 successful, 34 total, VERDICT command-exit 0.
  • ② pnpm --filter @object-ui/console type-check, which echoed tsc --noEmit && tsc -b tsconfig.node.json --force: VERDICT command-exit 0. tsc --listFilesOnly shows the program includes workspaceTimezonePromptLogic.ts, the dialog, SetupPage.tsx and the dialog's test.
  • ② pnpm exec vitest run on four files: WorkspaceTimezonePrompt.test.tsx; setupCreateTimezone-11908.test.tsx and authExitBasename.test.tsx (the two tests that import SetupPage); and machineLocaleCensus-9909.test.ts. Result: Test Files 4 passed (4), Tests 44 passed (44).
  • Census mechanism. With the rename in place and the census row still naming the old path, the census goes red: Tests 2 failed | 5 passed (7), in "no call site passes nothing, ..." and "every declared exemption matches exactly the sites it declares". The census reads files from disk, so the row has to follow the file.
  • ③ pnpm check:unreferenced-sources, pnpm check:test-path-roots and pnpm check:vi-mock-specifiers: exit 0 each.
  • ④ node scripts/check-changeset-presence.mjs, pnpm check:changeset-claims, pnpm check:pending-changeset-literals, pnpm check:control-bytes and pnpm check:new-line-citations (VERDICT new-cross-file-line-citations: 0 new citation(s)): exit 0 each.
  • ESLint, narrowed to the five touched source files: 5 files, 0 errors, 0 warnings, counted from --format json. For this diff the narrowing misses nothing. eslint.config.js extends tseslint.configs.recommended and sets no parserOptions.project or projectService, so type-aware linting is off. No rule under eslint-rules/ reads the filesystem. So the diff cannot change a verdict on an untouched file. pnpm lint itself runs in CI.
  • node scripts/check-governed-queue-guard.mjs --test on the diff's paths: NOT GOVERNED.

Changeset

.changeset/12184-timezone-prompt-module-rename.md declares @object-ui/console patch. check-changeset-presence counts two released packages, because the census test sits under packages/i18n/src/. The changeset declares only the console, as the claim set, because the i18n change is one test row and the fixed group bumps together.

Acceptance notes

  • Nothing found outside this card's scope. At 26b0bd2, the stem pin shows no other case-only stem pair in the tree.

Generated by Claude Code

…ides by case (objectui#12184)

`apps/console/src/pages/settings/` held `WorkspaceTimezonePrompt.tsx` (the
dialog) and `workspaceTimezonePrompt.ts` (its logic). Their extensionless
stems differ only in case, and TypeScript tries `.ts` before `.tsx`, so on a
case-insensitive filesystem (macOS APFS by default) the dialog's import
resolved to the logic file and `tsc` failed. Linux CI is case-sensitive and
stayed green.

The logic module is now `workspaceTimezonePromptLogic.ts` (a git mv, content
byte-identical). Its four readers follow: the dialog's import and doc
comment, the dialog's test, `SetupPage`, and the `@object-ui/i18n` machine
locale census row that names the file by path (that row's `file` only).
No behaviour, export or i18n key changes.

Claude-Session: https://claude.ai/code/session_016djJF12Qt14ejKR5Vjt4sK
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 291 chunks) 3179.1 KB 3204.6 KB
Main entry chunk (gzip) 74.1 KB 350 KB
Entry file index-DrWv87gb.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 20.05KB 7.41KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.11KB 7.97KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 588.51KB 141.71KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 243.13KB 67.92KB
fields (index.js) 279.78KB 71.29KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.26KB 11.71KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.31KB 15.86KB
plugin-charts (index.js) 84.72KB 23.27KB
plugin-chatbot (index.js) 201.72KB 48.07KB
plugin-dashboard (index.js) 144.20KB 38.95KB
plugin-designer (index.js) 233.77KB 50.02KB
plugin-detail (index.js) 250.93KB 66.24KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 177.74KB 46.01KB
plugin-gantt (index.js) 178.63KB 45.19KB
plugin-grid (index.js) 255.50KB 71.02KB
plugin-kanban (index.js) 53.23KB 16.71KB
plugin-list (index.js) 122.82KB 31.24KB
plugin-map (index.js) 27.24KB 9.03KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 44.12KB 12.29KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 92.11KB 23.27KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

CI: Test is red because Test (shard 1/8) hit its 20-minute ceiling, not because a test failed · domain:ui seat 1 · session_016djJF12Qt14ejKR5Vjt4sK · 2026-10-12T07:26Z

On head 5a2a86c306:

  • Test (shard 1/8) was cancelled at 20m16s (job 114699823457, run 38215707699, attempt 1). The annotation reads "The job has exceeded the maximum execution time of 20m0s".
  • The Test aggregate reads that as failure.
  • The other seven shards and Test (dist pins) are success.

Why this is not this PR's failure. The three facts in the seat's landing rule all hold:

  • No test failed. Every file the job reported before the cancel is ✓. The file in flight when it was cut was packages/plugin-form/src/ObjectForm.invalidationRefetch-10572.test.tsx. Its import closure does not meet this diff, which is one module rename in apps/console and one census row.
  • The same shard is green on the queue base. Test (shard 1/8) passed in the merge group that landed 26b0bd2 (run 38211460162, 9m54s).
  • The first error is the timeout, not an assertion.

This is the class objectui#9499 closed for shard 1/4, now on shard 1/8. Recent pull_request runs of Test (shard 1/8):

run duration
38209908789 17m48s
38215231563 18m01s
38207875462 (merge group) 17m29s
this run 20m16s, cancelled

The fix and the re-run.

  • No fix exists in a PR yet, and none belongs in this one.
  • The one re-run is warranted, but this seat cannot send it: the fleet relay refuses run re-runs by construction (scripts/pm/fleet-write/ops.mjs).
  • Someone with Actions write on this repo can re-run the failed job (run 38215707699, "Re-run failed jobs").

The seat keeps this PR watched. It enqueues once every check on 5a2a86c reads success or skipped by design. ACCEPT 6119454839 stands.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 12, 2026 13:09
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 12, 2026 13:09
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 12, 2026
Merged via the queue into main with commit 08b5d97 Oct 12, 2026
58 of 60 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12184-timezone-prompt-module-rename branch October 12, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants